Closed Bug 444407 Opened 12 years ago Closed 12 years ago

Progressbar should not be shown if column is to narrow or progress is 0%

Categories

(Calendar :: Calendar Views, enhancement)

enhancement
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: Fallen, Assigned: Fallen)

Details

Attachments

(1 file)

Attached patch Fix - v1Splinter Review
Christian suggested that the progressbar should not be shown at 0% to unclutter the UI. I've also found an easy way to only show a progressbar if the column has a minimum width.

* If progress is 0, nothing is shown
* If the progress column is wider than 75px, a progress meter is shown
* If the progress colum is narrower than 75px, the text form (i.e "30%") is shown
Attachment #328720 - Flags: ui-review?(christian.jansen)
Attachment #328720 - Flags: review?(Berend.Cornelius)
Attachment #328720 - Flags: review?(Berend.Cornelius) → review?(mschroeder)
Comment on attachment 328720 [details] [diff] [review]
Fix - v1

ui=christian
Attachment #328720 - Flags: ui-review?(christian.jansen) → ui-review+
Comment on attachment 328720 [details] [diff] [review]
Fix - v1

r=mschroeder with /dump(aCol.element.boxObject.width + "\n");/ removed
Attachment #328720 - Flags: review?(mschroeder) → review+
ah yes, sorry I missed that


Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.9
checked in lightning 2008072219 and sunbird 20080722 -> VERIFIED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.