444422 - hard-coded add-on guid prevents portability

Status: RESOLVED INCOMPLETE

(Toolkit Graveyard :: Data Collection/Metrics, defect)

Description

[Alex Polvi]

From Sergey Novikov @ Google: 

In src/nsProfileCollector.cpp in function nsProfileCollector::LogInstall which collects data about currently installed metrics extension. We had to add workaround in place where extension finds itself using it's extension id. The workaround is needed as the toolbar doesn't install separate metrics extension.

line 292: nsresult rv = em->GetItemForID(NS_LITERAL_STRING("[e-mail]"), getter_AddRefs(item));

When we run this code in the context of the toolbar we get exception because of trying to dereference item which is NULL.

The simplest workaround is to check if item is NULL.