444519 - oink -- gcc 4.3, flex-2.5.35, #include <ostream.h> to <ostream>, using namespace std;

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Gilles J. Seguin]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9) Gecko/2008061712 Fedora/3.0-1.fc9 Firefox/3.0
Build Identifier: oink current

- the gcc 4.3 compiler don't have <ostream.h> header
- name in std libraries must have they namespace specified.


Reproducible: Always

Steps to Reproduce:
1. cd oink
2. make

Actual Results:  
compiler says that <ostream.h> header are not found.


Expected Results:  
replace <ostream.h> header to <ostream>

Comment 1

[Gilles J. Seguin]

Attachment: diff file of the oink directory

- the "make" command line should succeed in oink directory.
- the "make" command line should succeed in oink-stack directory.
- the "make check" command line in the oink directory is not successful.

Comment 2

[Gilles J. Seguin]

Attachment: oink hg diff file

Comment 3

[Gilles J. Seguin]

Attachment: hg diff file of oink_file.h

Comment 4

[Gilles J. Seguin]

(In reply to comment #3)
> Created an attachment (id=332380) [details]
> hg diff file of oink_file.h
> 

attachment 332380 [details] [diff] [review] have lost comments
in attachment 331418 [details] [diff] [review] oink_file.h has change rindex() to strchr() should have been strrchr().

Comment 5

[(dormant account)]

Comment on attachment 331418 [details] [diff] [review]
oink hg diff file


>--- a/oink_file.h	Fri Jul 25 16:14:57 2008 -0700
>+++ b/oink_file.h	Sat Jul 26 09:38:43 2008 -0400
>@@ -6,17 +6,20 @@
> #define OINK_FILE_H
> 
> #include "astlist.h"
>+#include <cstring>
> #include <string>
> #include <stdio.h>
>+
>+using namespace std;

Don't use namespaces in header files. Fixed this and committed