444618 - Need support for Windows balloon tips

Status: RESOLVED FIXED

(Mozilla Labs :: Prism, defect)

Description

[Matthew Gertner]

Now that we have tray icon support on Windows, we should have a way to do proper balloon tips instead of the quirky Mozilla toaster alerts.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

modify nsIAlertsService for windows?

Comment 3

[Matthew Gertner]

Can't because tray icon support is required. We can deal with this when we fold
the binary components into the platform.

Comment 4

[Matthew Gertner]

Attachment: Implement balloon tips

(Shhhhhh... I snuck in the change to the version number as well.)

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 328947 [details] [diff] [review]
Implement balloon tips

>Index: runtime/components/public/nsIApplicationIcon.idl
>===================================================================
>+  
>+  /**
>+   * Display a popup balloon over the icon. Displays a normal alert (using nsIAlertsService) on

     * Display a specialized notification over the icon. Displays a normal alert (using nsIAlertsService) on

>+   * platforms that don't support balloon tips.

     * platforms that don't support specialized tips.

>+   */
>+  void showBalloonTip(in AString title,
>+                      in AString text,
>+                      in PRUint32 timeout,
>+                      [optional] in boolean textClickable,
>+                      [optional] in nsIObserver alertListener);
> };

How about "showNotificationTip" ? Balloon is so MS Windows

Comment 6

[Matthew Gertner]

Okay I changed it to showNotification.

Comment 7

[Matthew Gertner]

ending        confvars.sh
Sending        runtime/Makefile.in
Sending        runtime/components/public/nsIApplicationIcon.idl
Sending        runtime/components/src/mac/Makefile.in
Sending        runtime/components/src/mac/nsDockTile.mm
Sending        runtime/components/src/windows/nsNotificationArea.cpp
Sending        runtime/components/src/windows/nsNotificationArea.h
Transmitting file data .......
Committed revision 16985.