Soft hyphen misplaced in right-to-left text

RESOLVED FIXED

Status

()

RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: smontagu, Assigned: smontagu)

Tracking

({rtl, verified1.9.0.2})

unspecified
rtl, verified1.9.0.2
Points:
---
Bug Flags:
wanted1.9.0.x +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

11 years ago
Created attachment 328975 [details]
testcase

The soft hyphen in RTL text is correctly at the left of the line, but it needs to be shifted left by its own width so as not to overlap with the text.
Flags: wanted1.9.0.x?
(Assignee)

Comment 1

11 years ago
Created attachment 328981 [details] [diff] [review]
Patch
Attachment #328981 - Flags: superreview?(roc)
Attachment #328981 - Flags: review?(roc)
Attachment #328981 - Flags: superreview?(roc)
Attachment #328981 - Flags: superreview+
Attachment #328981 - Flags: review?(roc)
Attachment #328981 - Flags: review+
(Assignee)

Comment 2

11 years ago
Pushed as 6bf4f18446e2
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Flags: wanted1.9.0.x? → wanted1.9.0.x+
(Assignee)

Comment 3

11 years ago
Created attachment 334228 [details] [diff] [review]
Branch patch

Attachment 328981 [details] [diff] merged back to branch, and including post-checkin changes to the original reftest. Unfortunately the reftest has to be marked random unless bug 406299 gets into the branch.

The patch is low-risk, because it only changes behaviour for right-to-left text, and has been baking a good long time on trunk.
Attachment #334228 - Flags: superreview+
Attachment #334228 - Flags: review+
Attachment #334228 - Flags: approval1.9.0.3?
Comment on attachment 334228 [details] [diff] [review]
Branch patch

Let's take this in 1.9.0.2, you're clear to land.

Approved for 1.9.0.2. Please land in CVS. a=ss
Attachment #334228 - Flags: approval1.9.0.3? → approval1.9.0.2+
(Assignee)

Updated

11 years ago
Keywords: fixed1.9.0.2
Verified in 1.9.0.2 with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.2) Gecko/2008090212 Firefox/3.0.2.
Keywords: fixed1.9.0.2 → verified1.9.0.2
You need to log in before you can comment on or make changes to this bug.