Closed Bug 444656 Opened 16 years ago Closed 16 years ago

Soft hyphen misplaced in right-to-left text

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: smontagu, Assigned: smontagu)

Details

(Keywords: rtl, verified1.9.0.2)

Attachments

(3 files)

testcase
976 bytes, text/html
Details
Patch
4.40 KB, patch
roc
: review+
roc
: superreview+
Details | Diff | Splinter Review
Branch patch
6.49 KB, patch
smontagu
: review+
smontagu
: superreview+
samuel.sidler+old
: approval1.9.0.2+
Details | Diff | Splinter Review
Attached file testcase — 
The soft hyphen in RTL text is correctly at the left of the line, but it needs to be shifted left by its own width so as not to overlap with the text.
Flags: wanted1.9.0.x?
Attached patch Patch — — Splinter Review 

        Attachment #328981 -
        Flags: superreview?(roc)

        Attachment #328981 -
        Flags: review?(roc)

        Attachment #328981 -
        Flags: superreview?(roc)

        Attachment #328981 -
        Flags: superreview+

        Attachment #328981 -
        Flags: review?(roc)

        Attachment #328981 -
        Flags: review+

    
    

    
  
Pushed as 6bf4f18446e2
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Flags: wanted1.9.0.x? → wanted1.9.0.x+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Branch patch
        — 
          — Splinter Review
      

    


  
Attachment 328981 [details] [diff] merged back to branch, and including post-checkin changes to the original reftest. Unfortunately the reftest has to be marked random unless bug 406299 gets into the branch.

The patch is low-risk, because it only changes behaviour for right-to-left text, and has been baking a good long time on trunk.

        Attachment #334228 -
        Flags: superreview+

        Attachment #334228 -
        Flags: review+

        Attachment #334228 -
        Flags: approval1.9.0.3?

    
    

    
  
Comment on attachment 334228 [details] [diff] [review]
Branch patch

Let's take this in 1.9.0.2, you're clear to land.

Approved for 1.9.0.2. Please land in CVS. a=ss

        Attachment #334228 -
        Flags: approval1.9.0.3? → approval1.9.0.2+

    
  
Keywords: fixed1.9.0.2

    
    

    
  
Verified in 1.9.0.2 with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.2) Gecko/2008090212 Firefox/3.0.2.
Keywords: fixed1.9.0.2 → verified1.9.0.2

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: