Closed Bug 444660 Opened 12 years ago Closed 12 years ago

Firefox's connection settings box duplicates "H" accesskey

Categories

(Firefox :: Preferences, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 3.1a2

People

(Reporter: iann_bugzilla, Assigned: wladow)

Details

Attachments

(1 file)

If you bring up the Connection Settings box from the Advanced, Network pref pane you will see the "H" is duplicated between "HTTP Proxy" and "Help"
One solution is to:
Set accesskey for "HTTP Proxy" to "x"
Set accesskey for "Use this proxy server for all protocols" to "e"
Set accesskey for "Reload" to "d"
Attached patch v1Splinter Review
Solution used in this patch:
Set "L" for SSL Proxy (was "S")
Set "s" for Use this proxy server for all protocols (was "x")
Set "x" for HTTP Proxy -> avoid collision with Help button

I think this is a better solution, because Ian's "d" for "Reload" would sit under the last char of the string.
Assignee: nobody → wladow
Status: NEW → ASSIGNED
Attachment #331116 - Flags: review?(gavin.sharp)
Attachment #331116 - Flags: review?(gavin.sharp) → review+
http://hg.mozilla.org/index.cgi/mozilla-central/rev/bc5d9e73cb75
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1a2
The fourth "port:" field doesn't have an access key at all unlike the other four.  It should be added.  Perhaps "t" could be made the accesskey and then the fifth "port:" field, changed to use ":" as its access key?

~B
(In reply to comment #3)
> The fourth "port:" field doesn't have an access key at all unlike the other
> four.  It should be added.  Perhaps "t" could be made the accesskey and then
> the fifth "port:" field, changed to use ":" as its access key?
> 
> ~B
> 

Please file a new bug on that.
(In reply to comment #3)
> The fourth "port:" field doesn't have an access key at all unlike the other
> four.  It should be added.  Perhaps "t" could be made the accesskey and then
> the fifth "port:" field, changed to use ":" as its access key?
> 
> ~B
> 

There is a note in connection.dtd file:
<!-- No accesskey for gopher (':' doesn't go well) - mpt's going to redesign the window -->  
You need to log in before you can comment on or make changes to this bug.