444665 - Hookup geolocation prompt to fennec's notification prompt.

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 1

[Doug Turner (:dougt)]

Comment on attachment 328984 [details] [diff] [review]
patch v.1

basically the same thing as FF.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 328984 [details] [diff] [review]
patch v.1

>diff --git a/chrome/content/browser.js b/chrome/content/browser.js
>+
>+  setupGeolocationPrompt: function()
>+  {
>+    var geolocationService = Cc["@mozilla.org/geolocation/service;1"].getService(Ci.nsIGeolocationService);
>+    
>+    geolocationService.prompt = function(request) {
>+      
>+      var notificationBox = gBrowser.getNotificationBox();

        var notificationBox = Browser.getNotificationBox();

We don't have a gBrowser (and might not have one) so use "Browser" as shown.

>+        var message = bundle_browser.getFormattedString("geolocation.requestMessage", [request.requestingURI.spec]);      
>+        notificationBox.appendNotification(message,
>+                                           "geolocation",
>+                                           "chrome://browser/skin/Info.png",

This image does not exist in Fennec. We should get Madhava to make an image that fits the Fennec theme. Until then, just pass null.

r+ with those tweaks.

Comment 3

[Doug Turner (:dougt)]

changeset:   66:0c6c257bd42c
tag:         tip
user:        dougt@dougt-ubuntu
date:        Wed Jul 16 17:07:43 2008 -0700
summary:     Geolocation UI. Bug 444665. r=mfinkle

Comment 4

[Aakash Desai [:aakashd]]

verified FIXED (using share, more info and don't share) on builds:

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20090821
Fennec/1.0b3pre

and

Mozilla/5.0 (Macintosh; U; Intel Mac OSX 10.5; en-US; rv:1.9.2a2pre)
Gecko/20090808 Fennec/1.0b3pre