444689 - Make gfxMatrix::HasNonTranslation and friends more forgiving

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

We should allow an epsilon tolerance in these methods. Right now if you multiply a translation matrix by A and then by A-inverse it might no longer be considered a translation matrix.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

FuzzyEqual really shouldn't be inside gfxMatrix...

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Where do you want it?

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Yeah, that's a good question -- maybe in gfxTypes.h?  That's where we do the typedef for gfxFloat, maybe call it FloatFuzzyEquals or something (gfxFloatFuzzyEquals?)

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Hm. Thebes doesn't have any global functions yet I guess. Could you handle gfxPlatform::FuzzyEquals?

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Sure, though at that point we may as well do gfxUtils::FuzzyEquals?  There's probably other stuff we can dump onto gfxUtils as well

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix v2

move to gfxUtils

Comment 7

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 329022 [details] [diff] [review]
fix v2

Looks good, thanks!

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Pushed 9ec413364193.