Closed Bug 444748 Opened 12 years ago Closed 12 years ago

Get rid of custom timezone service

Categories

(Calendar :: Provider: GData, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Fallen, Assigned: Fallen)

Details

(Whiteboard: [gdata-0.5])

Attachments

(1 file)

The custom timezone service is not needed anymore, since we now internally use timezones in olsen form (i.e Europe/London).

I also noticed an error causing an endless password loop due to the fact that calGoogleCalendar didn't advertise calIGoogelCalendar in QI.

Is it possible that calendarDefaultTimezone() will return a foreign timezone? If so, then this will fail.
Attachment #329077 - Flags: review?(daniel.boelzle)
(In reply to comment #0)
> Is it possible that calendarDefaultTimezone() will return a foreign timezone?
> If so, then this will fail.

No, the timezone-service returns an internal (intrinsic) timezones (reason why defaultTimezone is part of calITimezoneService).
Comment on attachment 329077 [details] [diff] [review]
Remove tz service - v1

>-            var ctz = gdataTimezoneProvider.getShortTimezone(calendarDefaultTimezone());
>-            request.addQueryParameter("ctz", ctz);
>+            request.addQueryParameter("ctz", calendarDefaultTimezone().tzid);
etc

Can you be sure that Google knows all of our internal timezones? What happens if you configure a lightning timezone that Google doesn't know?

r=dbo with that explained
Attachment #329077 - Flags: review?(daniel.boelzle) → review+
(In reply to comment #2)
> Can you be sure that Google knows all of our internal timezones? What happens
> if you configure a lightning timezone that Google doesn't know?
Probably not 100%, but Google also uses Olson timezones. I'd rather not maintain my own list of Google timezones, since there is no way to get the timezones from the server without parsing the UI page in a browser that is logged in via AuthSub.

Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [gdata-cvs]
Target Milestone: --- → 0.9
Whiteboard: [gdata-cvs] → [gdata-0.5]
You need to log in before you can comment on or make changes to this bug.