444818 - nsGConfService fails to initialize problem

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Joshua Cranmer [:jcranmer]]

In trying to get new buildbots for Thunderbird set up, we found that the Linux builds were failing with gconf assertions for a test, failing in gconf_client_get_default() called from nsGConfService::Init; it seems that the problem is that g_type_init() was not called.

Even though TB is on 1.9.0.* ATM, it seems best to fix it on mozilla-central since TB trunk will be moving there shortly.

The fix should be simply to add g_type_init() before gconf_client_get_default() or maybe put it in nsGConfService::nsGConfService() itself to be on the safe side...

Comment 1

[Philippe M. Chiasson (:gozer)]

Attachment: Suggested patch

Comment 2

[Joshua Cranmer [:jcranmer]]

Without this applied, I verified that it reliably crashed if gconfd wasn't running (no crash if gconfd was running!). With it applied, I verify that it doesn't crash whether or not gconfd was running.

Comment 3

[Philippe M. Chiasson (:gozer)]

pushing to ssh://hg.mozilla.org/mozilla-central
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 1 changes to 1 files

changeset:   16125:bf06d3308793
http://hg.mozilla.org/mozilla-central/index.cgi/rev/bf06d3308793