444822 - Add documentation to UI code and some UI code fixes

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: UI code fixes - v1

This patch moves around some UI code to a more appropriate place and adds some documentation. This was originally part of the alarms patch.

Comment 1

[Berend Cornelius]

Comment on attachment 329129 [details] [diff] [review]
UI code fixes - v1

>-    var calendarToUse = aCalendarToUse || aItem.calendar;
>-    var calendars = getCalendarManager().getCalendars({});
>-    var indexToSelect = 0;
>-    var index = -1;
>+var calendarToUse = aCalendarToUse || aItem.calendar;
>+var calendars = getCalendarManager().getCalendars({});
>+var indexToSelect = 0;
>+var index = -1;

Why did you remove the indentation here? I think it's not conforming to our style guide and IMO should also not be taken over there as we do declaration and definition in one step.

"CreateAlarm" is never used in the project as I noticed. I don't mind providing it anyway but is there an important member that we should deliver (like the "icalString" for your "createDuration()" function)?
Patch is a good cleanup. r=berend

Comment 2

[Philipp Kewisch [:Fallen][📱📆]]

(In reply to comment #1)
> Why did you remove the indentation here? I think it's not conforming to our
> style guide and IMO should also not be taken over there as we do declaration
> and definition in one step.
Good catch, wasn't done on purpose.

> "CreateAlarm" is never used in the project as I noticed. I don't mind providing
> it anyway but is there an important member that we should deliver (like the
> "icalString" for your "createDuration()" function)?
> Patch is a good cleanup. r=berend
No parameters needed for now.


Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED

Comment 3

[Andreas Treumann]

Checked via mxr.mozilla.com -> VERIFIED