44491 - check that component's default owner and qa contact are valid bugzilla accounts

Status: VERIFIED DUPLICATE of bug 24806

(Bugzilla :: Bugzilla-General, defect, P3)

Description

[Blake Ross]

Networking now has two default owners, gagan and ruslan, and Networking: Cache 
also does -- neeti and gordon.  This just happened in the past couple of days.  
If this was not deliberate, this bug covers the fact that a module has two 
owners.  If, by chance, that _was_ deliberate, this bug covers the fact that in 
Bugzilla query lists, there should only be one owner per line.  With today's 
bug list, there's two networking bugs and the owner line says 
[e-mail], [e-mail].  Obviously that takes up a lot of 
room, leaving very little room for what perhaps is more important -- the 
summary line.  Thus, each owner email address should be displays on its own 
line.

Comment 1

[Blake Ross]

whatever this was, it's been fixed

Comment 2

[Matthew Tuck [:CodeMachine]]

Has it?

Bug #43786 on b.m.o exists and has a comma in the assignee.  This is a problem
since as far as I can tell (looking on Landfill), you can't make multiple
assignees any other way.

I think the database needs to be cleaned up.

It's possible that the default assignee is not being checked to be a valid user
before being placed there, whereas it is when the user inputs it.  I guess the
best solution in this case would be just to emit an error and fail to create the
bug.

If so, how would this multiple assignee have got through?  Is it entered through
editparams.cgi or something similar we could validate?  Or was it just entered
into a text file?

Perhaps sanitycheck.cgi could look at this, both making sure all bug reports
have valid addresses, and that the configuration addresses are correct?

Tara?

Comment 3

[Tara Hernandez]

Arg.  I'll have to go look at this.

Comment 4

[Blake Ross]

Yeah, somehow the default owner for networking and networking:cache got a 
little messed up, and two people got it.  Not only does this present annoying 
formatting problems in query lists, but Dawn said that neither of the two 
people get notification in this case.  sanitycheck should check when updated 
the default owners as well to prevent this in the future...

Comment 5

[Matthew Tuck [:CodeMachine]]

What we need here is:

- Everywhere to check addresses.  At least editcomponents.cgi doesn't at the
moment.
- sanitycheck.cgi to check addresses in the database
- sanitycheck.cgi or a separate config checking cgi to check all configuration
options, including the component addresses
- mozilla.org to fix the database
- mozilla.org to start running sanitycheck.cgi on a regular basis, which I don't
think they do (but see bug #45207).

Comment 6

[Chris Yeh]

this is specific to mozilla.org's installaton of bugzilla

Comment 7

[Matthew Tuck [:CodeMachine]]

Dawn, please assign back to Tara once you're sure this is gone from the
database, as there is still Bugzilla work to make sure this doesn't happen
again.

Comment 8

[Dawn Endico]

default owners of those components were fixed a while ago.

Changing the summary of this bug to reflect that bugzilla
should be fixed to disallow this sort of corruption. Nominating
for inclusion in 2.12.

Comment 9

[Blake Ross]

Yes, this is especially important and would be a good solution.  I recall a 
couple weeks ago when a typo caused [e-mail] (rather than 
[e-mail]) to be default QA for a new component, and no one realized 
it for quite awhile (so QA never received notification of those bugs...)

Comment 10

[Matthew Tuck [:CodeMachine]]

> default owners of those components were fixed a while ago.

Dawn, although the original problem is fixed, there's still corruption, see at
least
"http://bugzilla.mozilla.org/buglist.cgi?email1=%2C&emailtype1=substring&emailassigned_to1=1".

> I recall a couple weeks ago when a typo caused [e-mail]
> (rather than [e-mail]) to be default QA for a new component

Another good point.

It looks like bugzilla already stores these as user IDs, so Bugzilla must
actually be creating new accounts when this occurs!  Ideally it should fall over
in my opinion so the corruption can never enter the system.

Comment 11

[Chris Yeh]

this is actually related to 24806.

Comment 12

[Dawn Endico]

right. this is a dupe

*** This bug has been marked as a duplicate of 24806 ***

Comment 13

[Scott Brodmerkle]

Verified dupe.

Comment 14

[Dave Miller [:justdave]]

moving to Bugzilla product
reassign to default owner/qa for INVALID/WONTFIX/WORKSFORME/DUPLICATE