444911 - Middle/ctrl-click on the home button doesn't load tab in background when shift is pressed

Status: NEW

(Firefox :: General, defect)

Description

[Klaas Heidstra]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1a1pre) Gecko/2008062918 Minefield/3.1a1pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1a1pre) Gecko/2008062918 Minefield/3.1a1pre

From bug 440702 comment 34 :

BrowserGoHome() has a bug when you ctrl- or middle-click click it, it doesn't
make any difference if shift is pressed or not. It should open the homepage in
background when shift is pressed (and the pref is set to default), but instead
the new tab is selected. This is because of this code:
> // openUILinkIn in utilityOverlay.js doesn't handle loading multiple pages
> switch (where) {
> case "current":
>   loadOneOrMoreURIs(homePage);
>   break;
> case "tabshifted":
> case "tab":
>   urls = homePage.split("|");
>   var loadInBackground =
>getBoolPref("browser.tabs.loadBookmarksInBackground", false);
>   gBrowser.loadTabs(urls, loadInBackground);
>   break;
> case "window":
>   OpenBrowserWindow();
>   break;
> }

This problem can be fixed by replacing the above code with this:
> // openUILinkIn in utilityOverlay.js doesn't handle loading multiple pages
> var loadInBackground = getBoolPref("browser.tabs.loadBookmarksInBackground",
>false);
> switch (where) {
> case "current":
>   loadOneOrMoreURIs(homePage);
>   break;
> case "tabshifted":
>   loadInBackground = !loadInBackground;
>   // fall through
> case "tab":
>   urls = homePage.split("|");
>   gBrowser.loadTabs(urls, loadInBackground);
>   break;
> case "window":
>   OpenBrowserWindow();
>   break;
> }

Reproducible: Always

Steps to Reproduce:
1. Middle-click on the home-button while holding shift.
Actual Results:  
The homepage opens in a new SELECTED tab.

Expected Results:  
The tab should load in the background when loadBookmarksInBackground is set to false and the shift-button is pressed.

Comment 1

[Klaas Heidstra]

Attachment: patch - fix as described in comment #0

This patch fixes the problem.

Comment 2

[Klaas Heidstra]

Dão, what do you think of this patch?

Comment 3

[Klaas Heidstra]

Attachment: patch - update to tip, see comment #0 for description

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.