444996 - "‘INT_MAX’ was not declared in this scope" compiling nsPNGDecoder.cpp

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Andrew Schultz]

After http://hg.mozilla.org/index.cgi/mozilla-central/rev/bcbd2408632b, I fail compiling nsPNGDecoder.cpp,

modules/libpr0n/decoders/png/nsPNGDecoder.cpp:658: error: ‘INT_MAX’ was not declared in this scope

nsPNGDecoder.cpp needs to include limits.h

Comment 1

[Robert Longson [:longsonr]]

Attachment: patch (Checkin to 1.9.0.2: Comment 9)

Comment 2

[Robert Longson [:longsonr]]

Doesn't compile with Visual Studio 2003 either.

Comment 3

[Robert Longson [:longsonr]]

checked in.

Comment 5

[Evan Yan]

Comment on attachment 329439 [details] [diff] [review]
patch (Checkin to 1.9.0.2: Comment 9)

This patch needs to be landed on 1.9.0 branch as well. See bug 452194.

Comment 6

[Samuel Sidler (old account; do not CC)]

Comment on attachment 329439 [details] [diff] [review]
patch (Checkin to 1.9.0.2: Comment 9)

Approved for 1.9.0.2. Please land in CVS. a=ss

Comment 8

[Samuel Sidler (old account; do not CC)]

Robert, just fyi, if you want this in 1.9.0.2, we need it landed today before midnight PDT.

Comment 9

[Ian Neal]

Comment on attachment 329439 [details] [diff] [review]
patch (Checkin to 1.9.0.2: Comment 9)

Checking in 1.9.0.2
nsPNGDecoder.cpp; new revision: 1.83; previous revision: 1.82
done