Closed
Bug 444997
Opened 17 years ago
Closed 16 years ago
Allow /leave on a channel when disconnected (and use in /delete-view)
Categories
(Other Applications Graveyard :: ChatZilla, defect)
Other Applications Graveyard
ChatZilla
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bugzilla-mozilla-20000923, Assigned: glenjamin+bmo)
Details
(Whiteboard: [cz-0.9.85])
Attachments
(1 file)
|
2.79 KB,
patch
|
bugzilla-mozilla-20000923
:
review+
|
Details | Diff | Splinter Review |
Currently, we don't allow /leave to be executed on a channel when there is no connected server. However, we track "joined" and "active" states for channels, so there is no reason not to allow this (and just set "joined" to false).
In particular, /delete-view should be updated to call /leave when a channel is "joined" - even if it isn't "active". Otherwise, if a user deletes a channel view while disconnected, we'll rejoin them when reconnected.
|
Assignee | |
Comment 1•16 years ago
|
||
Delete view calls part if joined
cmdLeave sets joined=false if not active
Patch also strips some trailing whitespace from other places, fight the lint count!
Assignee: rginda → glenjamin+bmo
Attachment #381978 -
Flags: review?(silver)
|
Reporter | |
Updated•16 years ago
|
Attachment #381978 -
Flags: review?(silver) → review+
|
|
Reporter | |
Comment 2•16 years ago
|
||
Comment on attachment 381978 [details] [diff] [review]
allow leaving channels when offline
(e.view.active || e.view.joined) should be just e.view.joined; a channel cannot be active without also being joined.
r=silver otherwise.
|
|
Reporter | |
Updated•16 years ago
|
Status: NEW → ASSIGNED
|
|
Reporter | |
Comment 3•16 years ago
|
||
Checked in --> FIXED.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: [cz-0.9.85]
|
||
Updated•9 months ago
|
Product: Other Applications → Other Applications Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•