445093 - Update zh-TW Yahoo! Search URL and Favicon

Status: RESOLVED FIXED

(Mozilla Localizations :: zh-TW / Chinese (Traditional), defect)

Description

[Jia Mi [:mijia]]

Hi,

Yahoo! Taiwan recently updated their search link and some icons. They want us to update them in our zh-TW (traditional Chinese) version Firefox 3.0. Can we do this in our coming version 3.0.1? 

(1) Yahoo! search link in search box FF3 need to be updated to -
http://tw.rd.yahoo.com/referurl/ff3/srchbox/web/*http://tw.search.yahoo.com/search?fr=ffds1&p={keyword}

(2) Correct icon in search box FF3 for Yahoo! Knowledge search(知識+) http://us.i1.yimg.com/us.yimg.com/i/tb/icons/tw_ks.gif

(3) Correct icon in search box FF3 for Yahoo! Auction search(拍賣) http://us.i1.yimg.com/us.yimg.com/i/tb/icons/auc_1.gif

Comment 1

[:Gavin Sharp [email: [e-mail]]]

3.0.1 is going to be shipping very shortly, so it's too late to change it there. Should be able to get it into 3.0.2 though.

Comment 2

[Axel Hecht [:Pike]]

Sob, why does everybody think that redirecting users around the world is a good idea? And we'd been tracking twice? There are similar discussions like this internally, I'll see if there's knowledge to carry over.

I don't see us blocking 3.0.2 on this, btw.

Comment 3

[Jia Mi [:mijia]]

Yeah, can we have those on 3.0.2?
Thank you very much.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I'll create patched files for these changes.

By the way, what should I do to make Bugzilla assign all newly-created zh-TW component bugs to me?

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Patch for Yahoo search plugins

Comment 6

[Axel Hecht [:Pike]]

Comment on attachment 330177 [details] [diff] [review]
Patch for Yahoo search plugins

r,a=me, please land this with a check-in comment referencing this bug and my review/approval. Something like "bug 445093, change yahoo search engine icons and urls, r=[e-mail]" would do.

Make sure to land this on both CVS and mercurial.

Regarding the bug assigning, the common habit is to assign bugs to one self as soon as you start to actually work on it. I have set your bugzilla privs so that you can actually do that, use the new power carefully, please.

Comment 7

[Samuel Sidler (old account; do not CC)]

Not blocking per comment 2, but the patch has already been approved and needs to land.

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to comment #7)
> Not blocking per comment 2, but the patch has already been approved and needs
> to land.
> 

I'll do that this weekend, I promise :(

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Patch landed.

http://mxr.mozilla.org/l10n/source/zh-TW/browser/searchplugins/
http://hg.mozilla.org/l10n-central/zh-TW/index.cgi/rev/0b5049790e95