Hardcode of DESKTOP for OS2_DesktopDirectory is not NLS enabled

VERIFIED FIXED

Status

()

Core
XPCOM
P3
normal
VERIFIED FIXED
18 years ago
18 years ago

People

(Reporter: mkaply, Assigned: Jessica Blanco)

Tracking

Trunk
x86
OS/2
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

18 years ago
See:

http://lxr.mozilla.org/seamonkey/source/xpcom/io/nsSpecialSystemDirectory.cpp#82
7

We can use the API WinQueryActiveDesktopDirectory to get this value.
(Reporter)

Comment 1

18 years ago
This was code originally done by Jessica. We need to add this change.
Assignee: mkaply → jblanco
(Assignee)

Comment 2

18 years ago
Created attachment 11411 [details] [diff] [review]
Made changes so the OS2_DesktopDirectory is no longer hardcoded.
(Assignee)

Comment 3

18 years ago
Doug, could you please review the attached diff?
(Assignee)

Updated

18 years ago
Status: NEW → ASSIGNED

Comment 4

18 years ago
I am not an os2 hacker (sorry).  It looks fine to me if you say so.  2 
questions, WinQueryActiveDesktopPathname() makes to append a slash and a null?  
Are you sure that you are not clobbering the trailing char?  Also, shouldn't you 
check for a buffer overwrite?  
(Assignee)

Comment 5

18 years ago
Created attachment 11520 [details] [diff] [review]
Thanks for the update, Doug. How does the change look now?

Comment 6

18 years ago
Doug,
Are you ok w/Jessica's latest changes? Thanks,
Skip

Comment 7

18 years ago
yes.  r=dougt.  
(Reporter)

Comment 8

18 years ago
I checked in this fix.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 9

18 years ago
please verify
(Reporter)

Comment 10

18 years ago
Verified this is fixed
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.