445186 - Weave Sign-In Dialog "Cancel" button doesn't actually cancel anything, while I'm signing in

Status: RESOLVED FIXED

(Cloud Services :: General, defect, P3)

Description

[Daniel Holbert [:dholbert]]

Steps to reproduce:
 1. Open up Weave Sign In Dialog (Click Weave icon, choose "Sign In").
 2. Click "Sign In" on dialog.
 3. Press "Cancel" at any time while Weave is signing in.

ACTUAL RESULTS:
  Dialog disappears, which seems to indicate that Weave has accepted your command, but **Weave still signs in**.

EXPECTED RESULTS:
  *Option A) Weave cancels your sign-in. (Weave status bar should go back to "Offline"/"Sign In".)
  *Option B) "Cancel" button is disabled during the sign-in process (since it doesn't seem to have any useful purpose at that time).

Option B seems simpler to me.
(Though if Labs actually wants in-progress Weave Sign-Ins to be cancellable, then "Cancel" should be available actually work, per Option A)

VERSION INFO:
Ubuntu Linux 8.04
Firefox 3.0.0
Weave 0.2.4

Comment 1

[Daniel Holbert [:dholbert]]

(In reply to comment #0)
> (Though if Labs actually wants in-progress Weave Sign-Ins to be cancellable,
> then "Cancel" should be available actually work, per Option A)

oops - I meant "should be available _and_ actually work"

Comment 2

[Daniel Holbert [:dholbert]]

(In reply to comment #0)
> EXPECTED RESULTS:
> [...]

  *Option C) Perhaps the "Cancel" button could change a "Hide" button while Weave is undergoing its sign-in process, and it's function would remain the same -- make the dialog go away, but continue logging in.

This seems like a reasonable option, because it more accurately describes what the button does (at least currently).

Comment 3

[Dan Mills [:thunder]]

Were you listening in to our meeting today?  This is exactly what Chris suggested ;-)  Though he was talking about the modal sync dialog, not the sign in dialog.

Comment 4

[Daniel Holbert [:dholbert]]

Nope, I wasn't. :)  A "Hide" button sounds like a great idea for both sign in and sync dialogs.

My point with this bug, though, is that Weave already has a "Hide" button for the sign-in dialog -- it's just labeled "Cancel" instead of "Hide". :)

Comment 5

[Ed Lee :Mardak]

http://hg.mozilla.org/labs/weave/rev/681fbeb9b875

Just relabel Cancel to Hide (but keep around the original (localized) label in case we fail)