44523 - table layout wrong, rowspan/colspan problem?

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect, P3)

Description

[Jeremy Browne (no email)]

From Bugzilla Helper:
User-Agent: Mozilla/4.73 [en] (Win98; U)
BuildID:    2000070320

The (differently sized) cells in a table that uses rowspan, colspan, and valign 
have been laid out incorrectly in mozilla builds for the past two or so weeks.

Reproducible: Always
Steps to Reproduce:
1. Go to listed url using any recent Mozilla build. This is probably cross 
platform, but I haven't been able to get a working build on linux for a while. 
You'll need to scroll down a little bit to see the problem.


Actual Results:  Wonky layout

Expected Results:  Layout similar to what is seen in Communicator.

This may be a dupe of a valign bug, I'm not experienced enough with tables to 
say.
Probably should be fixed for nsbeta2 as this is one of the top few Canadian 
sites traffic-wise.

Comment 1

[Jeremy Browne (no email)]

Attachment: Recent page source. This causes Mozilla to freeze when accessed via file:// on my computer. (haven't tried it remotely)

Comment 2

[Bernd Mielke]

Attachment: tetstcase with BR and P tag

Comment 3

[Bernd Mielke]

The testcase has an <p> and <br> tag at places where they are not allowed
(validator.w3.org) If one removes these tages the page and the testcase renders
fine. I think the bug is invalid

Comment 4

[Matthew Cline]

Works for me on Linux build 20000701.

Comment 5

[Bernd Mielke]

Confirming the bug. I see the problem also under WinNT with 2000071620.

Comment 6

[Peter Lubczynski]

http://www.canoe.ca looks fine to me (NT Gecko/20000817)

I can't see this bug but the page never stops loading (another bug)

Comment 7

[Bernd Mielke]

Problem is still present with 2000090804 win98

Comment 8

[Christine Hoffman]

Using 9/18 build on Win 98, page looks okay. What is the specific problem?

Comment 9

[Bernd Mielke]

The picture has indeed changed, while in the second testcase with 2000090804 the
two items have overlayed now the second item is not displayed anymore. No german
beer visbible == horked. (Use Nav to see the german beer :-))

Comment 10

[Jonas Linde]

Attachment: Is this the same bug? I think so.

Comment 11

[DS]

Check out my site at http://www.attackproductions.com/nvidia/
The headlines table renders correctly with IE or Netscape 4, but not with 
Mozilla M18/Netscape 6.  Someone please get this fixed.

Comment 12

[karnaze (gone)]

Moving to m0.9.1

Comment 13

[Amarendra Hanumanula]

QA contact update

Comment 14

[karnaze (gone)]

Attachment: slightly simplified test case with 2 rows

Comment 15

[karnaze (gone)]

Hyatt, in attachment #4 [details] [diff] [review], while processing the children of the 2nd row in 
nsCSSFrameConstructor::TableProcessChildren, the ChildIterator is not returning 
the content via nsBindingManager::GetXBLChildNodesFor. Please reassign back to 
me if the test cases still fail after you fix this.

Comment 16

[karnaze (gone)]

Forget that last bogus comment. Reassigning back to me.

Comment 17

[karnaze (gone)]

Attachment: patch to fix the bug

Comment 18

[karnaze (gone)]

Moving to m0.9

Comment 19

[Bernd]

r=bernd for the patch, I see the german beer.

Comment 20

[karnaze (gone)]

Attachment: a test case with multiple <tbody>s to exercise patch

Comment 21

[karnaze (gone)]

Attachment: better patch to handle all test cases (ignore previous one)

Comment 22

[Marc Attinasi]

sr=attinasi

Comment 23

[karnaze (gone)]

The patch is in.