TM: Make sure we don't record across calls that copy argv (or track this copying).

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: gal, Assigned: shaver)

Tracking

unspecified
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite -
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

10 years ago
 
(Reporter)

Comment 1

10 years ago
A simple trace abort would be fine. But this should be fixed before we land and I don't know how to do it. Assigning it randomly to someone who I think knows how to fix it.
Assignee: general → shaver
I actually fixed this but did not update the comment. From TraceRecorder::interpretedFunctionCall:

    // TODO: make sure args are not copied, or track the copying via the tracker
    if (argc < fun->nargs &&
        jsuword(fp->regs->sp + (fun->nargs - argc)) > cx->stackPool.current->limit) {
        ABORT_TRACE("can't trace calls with too few args requiring argv move");
    }   

Fixing the comment now.

/be
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
Flags: in-litmus-
You need to log in before you can comment on or make changes to this bug.