uninstall\helper.EXE does not contain a value for "Original file name"

VERIFIED FIXED

Status

()

VERIFIED FIXED
10 years ago
10 years ago

People

(Reporter: samuel.sidler+old, Assigned: rstrong)

Tracking

({verified1.8.1.17, verified1.9.0.2})

3.0 Branch
x86
Windows XP
verified1.8.1.17, verified1.9.0.2
Points:
---
Bug Flags:
blocking1.9.0.2 -
wanted1.9.0.x +
blocking1.8.1.17 -
wanted1.8.1.x +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

Working with one of our AV vendors, they informed me that helper.exe, while signed, does not include a value for "Original file name". Getting that value added would help them a lot. Not sure if this is part of the signing process or something we need to do in Firefox, so move appropriately.
IIRC, that file is created by NSIS.
Component: Release Engineering → Installer
Product: mozilla.org → Firefox
QA Contact: release → installer
Version: other → 3.0 Branch
(Reporter)

Comment 2

10 years ago
We should really find a way to fix this for our AV vendors. Requesting blocking all around.
Flags: blocking1.9.0.2?
Flags: blocking1.8.1.17?
Flags: blocking-firefox3.1?
Taking - this is fairly trivial to fix. Are there any other file attributes they would like added?
Assignee: nobody → robert.bugzilla
(Reporter)

Comment 4

10 years ago
That's the only executable they mentioned and that's the only file attribute mentioned. Do installers also have file attributes? If not, we might want to add one as well, if it makes sense to do so. (Note: I haven't yet checked with the vendor about that. I'll do so before we make any change like that.)
Yes, installers also have these same attributes and I'll be adding this at the same time to the installer exe contained within the 7-Zip SEA (self extracting archive). The 7-Zip SEA also has these attributes and would need to be modified separately.
Created attachment 331268 [details] [diff] [review]
patch installer (setup.exe) and uninstaller (helper.exe)
Attachment #331268 - Flags: review?(jmathies)
Comment on attachment 331268 [details] [diff] [review]
patch installer (setup.exe) and uninstaller (helper.exe)

Jim, I've also done a little cleanup of the files including making it a requirement for NSIS 2.22. This was added initially due to not all Firefox tinderboxes being upgraded when it was first added.
Note: the 7-Zip stub has an Original Filename of OriginalFilename 7zS.sfx.exe

Comment 9

10 years ago
Comment on attachment 331268 [details] [diff] [review]
patch installer (setup.exe) and uninstaller (helper.exe)

Looks good to me.

Are these macros now inserted by default? -

!insertmacro un.LineFind  
!insertmacro un.TrimNewLines
Attachment #331268 - Flags: review?(jmathies) → review+
(In reply to comment #9)
> (From update of attachment 331268 [details] [diff] [review])
> Looks good to me.
> 
> Are these macros now inserted by default? -
> 
> !insertmacro un.LineFind  
> !insertmacro un.TrimNewLines 
Yes, in common.nsh where they are used
Checked in to mozilla-central

changeset:   16262:45f11b174072
tag:         tip
user:        Robert Strong <robert.bugzilla@gmail.com>
date:        Sun Jul 27 18:46:47 2008 -0700
summary:     Bug 445276 - uninstall\helper.EXE does not contain a value for Original file name. r=jmathies
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Comment on attachment 331268 [details] [diff] [review]
patch installer (setup.exe) and uninstaller (helper.exe)

Drivers, this is a simple change with a small amount of cleanup
Attachment #331268 - Flags: approval1.9.0.2?
Comment on attachment 331268 [details] [diff] [review]
patch installer (setup.exe) and uninstaller (helper.exe)

Approved for 1.9.0.2. Please land in CVS. a=ss
Attachment #331268 - Flags: approval1.9.0.2? → approval1.9.0.2+
This should block either branch release, however. What idiot requested it? ;)

Rob, can we get a 1.8 branch patch for this as well?
Flags: wanted1.9.0.x+
Flags: wanted1.8.1.x+
Flags: blocking1.9.0.2?
Flags: blocking1.9.0.2-
Flags: blocking1.8.1.17?
Flags: blocking1.8.1.17-
(In reply to comment #14)
> This should block either branch release, however. What idiot requested it? ;)
> 
> Rob, can we get a 1.8 branch patch for this as well?
Will do.
Checked in for 1.9.0.2 / Firefox 3.0.2

Checking in mozilla/toolkit/mozapps/installer/windows/nsis/version.nsh;
/cvsroot/mozilla/toolkit/mozapps/installer/windows/nsis/version.nsh,v  <--  vers
ion.nsh
new revision: 1.4; previous revision: 1.3
done
Checking in mozilla/browser/installer/windows/nsis/installer.nsi;
/cvsroot/mozilla/browser/installer/windows/nsis/installer.nsi,v  <--  installer.
nsi
new revision: 1.45; previous revision: 1.44
done
Checking in mozilla/browser/installer/windows/nsis/uninstaller.nsi;
/cvsroot/mozilla/browser/installer/windows/nsis/uninstaller.nsi,v  <--  uninstal
ler.nsi
new revision: 1.21; previous revision: 1.20
done
Keywords: fixed1.9.0.2
Created attachment 332306 [details] [diff] [review]
simplified patch for the 1.8 branch

Per comment #14
Attachment #332306 - Flags: review+
Attachment #332306 - Flags: approval1.8.1.17?
Flags: blocking-firefox3.1?
Comment on attachment 332306 [details] [diff] [review]
simplified patch for the 1.8 branch

Approved for 1.8.1.17, a=dveditz for release-drivers.
Attachment #332306 - Flags: approval1.8.1.17? → approval1.8.1.17+
Checked in to MOZILLA_1_8_BRANCH

Checking in mozilla/browser/installer/windows/nsis/installer.nsi;
/cvsroot/mozilla/browser/installer/windows/nsis/installer.nsi,v  <--  installer.
nsi
new revision: 1.3.2.29; previous revision: 1.3.2.28
done
Checking in mozilla/browser/installer/windows/nsis/uninstaller.nsi;
/cvsroot/mozilla/browser/installer/windows/nsis/uninstaller.nsi,v  <--  uninstal
ler.nsi
new revision: 1.1.2.8; previous revision: 1.1.2.7
done
Checking in mozilla/toolkit/mozapps/installer/windows/nsis/version.nsh;
/cvsroot/mozilla/toolkit/mozapps/installer/windows/nsis/version.nsh,v  <--  vers
ion.nsh
new revision: 1.2.2.3; previous revision: 1.2.2.2
done
Keywords: fixed1.8.1.17
Verified FIXED using:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.17) Gecko/20080829 Firefox/2.0.0.17

Replacing fixed1.8.1.17 with verified1.8.1.17.
Keywords: fixed1.8.1.17 → verified1.8.1.17
verified fixed for 1.9.0.2 using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.2) Gecko/2008090213 Firefox/3.0.2

--> Verified fixed
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.0.2 → verified1.9.0.2
You need to log in before you can comment on or make changes to this bug.