Closed Bug 445281 Opened 16 years ago Closed 2 years ago

Automate litmus test Testcase ID #4605 - Selection retention after clicking on buttons/controls

Categories

(Toolkit :: Downloads API, defect)

defect
Not set
normal

Tracking

()

RESOLVED INCOMPLETE

People

(Reporter: poonaatsoc, Unassigned)

References

()

Details

Attachments

(1 file, 1 obsolete file)

Proposed type of test: chrome

Proposed location of test: toolkit/mozapps/downloads/tests/chrome
Attached patch v1.0 (obsolete) — Splinter Review
The test works perfectly.

The test succeeds as expected for cancel and pause buttons, and fails as expected for retry button.  Tomcat and I had a discussion and we concluded that retry shouldn't be there as a testcase, since the download doesn't retain selection when one clicks on its retry button and hence that testcase fails in the test too.  Though tomcat edited the litmus test, which now has only pause and cancel testcases, I have still included even the retry testcase in the testfile since I wanted to discuss this with stephen and wanted you to decide on it.
Attachment #330409 - Flags: review?(sdwilsh)
Attached patch v2.0Splinter Review
Test updated to accommodate the updated utils.js.  The test passes
Attachment #330409 - Attachment is obsolete: true
Attachment #331487 - Flags: review?(sdwilsh)
Attachment #330409 - Flags: review?(sdwilsh)
Product: Firefox → Toolkit
Comment on attachment 331487 [details] [diff] [review]
v2.0

>diff --git a/toolkit/mozapps/downloads/tests/chrome/Makefile.in b/toolkit/mozapps/downloads/tests/chrome/Makefile.in
>--- a/toolkit/mozapps/downloads/tests/chrome/Makefile.in
>+++ b/toolkit/mozapps/downloads/tests/chrome/Makefile.in
>@@ -62,6 +62,7 @@ _CHROME_FILES = \
>   test_queued_download_context.xul \
>   test_remove_download_pre_select_next_file.xul \
>   test_removeDownload_updates_ui.xul \
>+  test_retention_after_button_click.xul \
nit: this name isn't great.  retention happens to be the name of a download manager preference, but I don't think it applies in this situation

Overall, this test isn't good because if you try to pause/cancel an in-progress download the the backend doesn't know about (which happens with fake data), it'll throw an exception.  I can't see that working well for this test.
Attachment #331487 - Flags: review?(sdwilsh) → review-

Mass-removing myself from cc; search for 12b9dfe4-ece3-40dc-8d23-60e179f64ac1 or any reasonable part thereof, to mass-delete these notifications (and sorry!)

The bug assignee didn't login in Bugzilla in the last 7 months.
:mak, could you have a look please?
For more information, please visit auto_nag documentation.

Assignee: poonaatsoc → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(mak)
Status: NEW → RESOLVED
Closed: 2 years ago
Flags: needinfo?(mak)
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: