445369 - Allow closing tabs in the Ctrl+Tab panel with Ctrl+W

Status: VERIFIED FIXED

(Firefox :: Keyboard Navigation, enhancement)

Description

[Dão Gottwald [:dao]]

From <http://en.design-noir.de/mozilla/ctrl-tab/?com#c:71>:

"Great job!
But I miss a feature. When ctrl+tabbing I would like to be able to close the tab by pressing ctrl+W.
Didn’t get it? This is what i would like:
Hold ctrl
Tap tab(to open your wonderful extension/choose tab)
Tap W(to close selected tab)

In my opinion it’s much easier than switching tab before you can close it."

Comment 1

[Dão Gottwald [:dao]]

Attachment: patch

Comment 2

[Dão Gottwald [:dao]]

Attachment: better patch

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 329741 [details] [diff] [review]
better patch

This causes trouble with browser.ctrlTab.previewsCount > 3. Probably a good idea to drop that pref anyway.

Comment 4

[Dão Gottwald [:dao]]

Attachment: v3

Comment 5

[Dão Gottwald [:dao]]

This can be tested with the latest version of the extension.

Comment 6

[Dão Gottwald [:dao]]

Attachment: v3, updated and merged

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

As described in bug 445495 it would improve the user experience if you don't hard-code the number of shown previews to 3. Having a long list of tabs will make it really hard to find the right one. Further using 5 previews would be a good initial value.

Comment 8

[Dão Gottwald [:dao]]

See bug 445495 comment 6.

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 330358 [details] [diff] [review]
v3, updated and merged

Yeah, this makes sense.

We should probably also look at adding support for using the left and right arrows as a way of moving back and forth while the preview window is open; is there already a bug on that?

Comment 10

[Dão Gottwald [:dao]]

(In reply to comment #9)
> We should probably also look at adding support for using the left and right
> arrows as a way of moving back and forth while the preview window is open; is
> there already a bug on that?

No, I'll file one.

Comment 11

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 330358 [details] [diff] [review]
v3, updated and merged

It would be nice if this code had a few more comments in general. Some of the "magic numbers" particularly are a bit opaque especially now that some of the code assumes a constant visibleCount==3.

Comment 12

[Dão Gottwald [:dao]]

I don't think any code that I touch here assumes visibleCount==3. (Otherwise, I'd like to fix that.) The magic numbers are due to the fact that this.selected is always the second-visible preview, even if you set browser.ctrlTab.previewsCount > 3 without this patch applied. I'll add some comments in this regard.

Comment 13

[Dão Gottwald [:dao]]

http://hg.mozilla.org/index.cgi/mozilla-central/rev/d5743c68c91a

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The fix regressed bug 450049 at least on OS X.

Comment 15

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/index.cgi/rev/2914186bef5c

Comment 16

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified with:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1a2pre) Gecko/20080812022114 Minefield/3.1a2pre ID:20080812022114

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1a2pre) Gecko/20080812045727 Minefield/3.1a2pre ID:20080812045727