Closed Bug 445369 Opened 12 years ago Closed 12 years ago

Allow closing tabs in the Ctrl+Tab panel with Ctrl+W

Categories

(Firefox :: Keyboard Navigation, enhancement)

enhancement
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 3.1a2

People

(Reporter: dao, Assigned: dao)

References

()

Details

Attachments

(1 file, 3 obsolete files)

From <http://en.design-noir.de/mozilla/ctrl-tab/?com#c:71>:

"Great job!
But I miss a feature. When ctrl+tabbing I would like to be able to close the tab by pressing ctrl+W.
Didn’t get it? This is what i would like:
Hold ctrl
Tap tab(to open your wonderful extension/choose tab)
Tap W(to close selected tab)

In my opinion it’s much easier than switching tab before you can close it."
Summary: Allow closing a tab in the Ctrl-Tab panel → Allow closing tabs in the Ctrl+Tab panel with Ctrl+W
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → dao
Status: NEW → ASSIGNED
Flags: wanted-firefox3.1?
Keywords: uiwanted
Attached patch better patch (obsolete) — Splinter Review
Attachment #329710 - Attachment is obsolete: true
Comment on attachment 329741 [details] [diff] [review]
better patch

This causes trouble with browser.ctrlTab.previewsCount > 3. Probably a good idea to drop that pref anyway.
Attachment #329741 - Attachment is obsolete: true
Attached patch v3 (obsolete) — Splinter Review
Attachment #329799 - Flags: ui-review?(beltzner)
This can be tested with the latest version of the extension.
Blocks: 445573
Attachment #329799 - Flags: review?(gavin.sharp)
Blocks: 446065
Attachment #329799 - Attachment is obsolete: true
Attachment #330358 - Flags: ui-review?(beltzner)
Attachment #330358 - Flags: review?(gavin.sharp)
Attachment #329799 - Flags: ui-review?(beltzner)
Attachment #329799 - Flags: review?(gavin.sharp)
Flags: wanted-firefox3.1?
As described in bug 445495 it would improve the user experience if you don't hard-code the number of shown previews to 3. Having a long list of tabs will make it really hard to find the right one. Further using 5 previews would be a good initial value.
Comment on attachment 330358 [details] [diff] [review]
v3, updated and merged

Yeah, this makes sense.

We should probably also look at adding support for using the left and right arrows as a way of moving back and forth while the preview window is open; is there already a bug on that?
Attachment #330358 - Flags: ui-review?(beltzner) → ui-review+
(In reply to comment #9)
> We should probably also look at adding support for using the left and right
> arrows as a way of moving back and forth while the preview window is open; is
> there already a bug on that?

No, I'll file one.
Keywords: uiwanted
Comment on attachment 330358 [details] [diff] [review]
v3, updated and merged

It would be nice if this code had a few more comments in general. Some of the "magic numbers" particularly are a bit opaque especially now that some of the code assumes a constant visibleCount==3.
Attachment #330358 - Flags: review?(gavin.sharp) → review+
I don't think any code that I touch here assumes visibleCount==3. (Otherwise, I'd like to fix that.) The magic numbers are due to the fact that this.selected is always the second-visible preview, even if you set browser.ctrlTab.previewsCount > 3 without this patch applied. I'll add some comments in this regard.
http://hg.mozilla.org/index.cgi/mozilla-central/rev/d5743c68c91a
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1a2
The fix regressed bug 450049 at least on OS X.
Verified with:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1a2pre) Gecko/20080812022114 Minefield/3.1a2pre ID:20080812022114

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1a2pre) Gecko/20080812045727 Minefield/3.1a2pre ID:20080812045727
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.