Closed Bug 445492 Opened 16 years ago Closed 16 years ago

Use 'DEL' key to delete an event of a rule -> 'Deleting Repeating Event' dialog starts two times.

Categories

(Calendar :: Calendar Frontend, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: andreas.treumann, Assigned: Fallen)

Details

Attachments

(1 file)

STEPS TO REPRODUCE:
===================

- select a single event of a recurring event
- push the 'Del' key
- the 'Delete Repeating Event' dialog is visible
- mouse clicking 'Delete just this occurrence' or 'Delete all occurrences'

RESULT:
=======

- the 'Delete Repeating Event' dialog starts a second time


EXPECTED RESULT:
================

- the dialog shouldn't starts a second time

REPRODUCIBLE:
=============

- always

Same on a WCAP calendar via context menu or delete icon works.
Flags: wanted-calendar0.9?
Needs investigation; I doubt this is related to WCAP, but a general problem with async providers.
Flags: wanted-calendar0.9? → blocking-calendar0.9+
Berend, could you take a look into this bug too? Daniel will help out if needed.
Assignee: nobody → Berend.Cornelius
I couldn't reproduce this issue using cal-emea and the latest nightlies.
I can reproduce that, the dialog pops up twice.
Not only does the dialog pops up twice, but the CalDAV requests are also
performed twice.

For the removal of a specific recurrence instance you'll see the following sequence of requests: PUT, REPORT, PUT, REPORT.

For the removal of a calendar object resource you'll see two DELETE requests.

I'm my opinion this should be blocking 0.9 since it is a regression compared to 0.8.
Assignee: Berend.Cornelius → nobody
Is there a event.stopPropagation(); missing or a event.preventBubble(); that didn't get changed when we moved to Gecko 1.9?
Component: Provider: WCAP → Calendar Views
QA Contact: wcap-provider → views
Summary: Use 'DEL' key to delete an event of a WCAP rule -> 'Deleting Repeating Event' dialog starts two times. → Use 'DEL' key to delete an event of a rule -> 'Deleting Repeating Event' dialog starts two times.
Attached patch Fix - v1 β€” β€” Splinter Review
The problem here is that two different locations react on the delete button. One location is keypress handler in the month and multiday views, the other is the general hotkey mechanism that deletes selected events when the "Del" button is pressed. I favored removing the keypress handlers, since it allows removing more code while keeping functionality.
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #333138 - Flags: review?(daniel.boelzle)
Looks like you remove a bunch of the inline editing code. What happens with your patch applied if inline editing is active and the user presses Del to remove a character from the event title? Does this remove the character or the entire event?
Whiteboard: [patch in hand] [needs-review]
I tested that and it seems to work. I guess in a textbox some keys are reserved and cannot be overridden by a <key>.
Comment on attachment 333138 [details] [diff] [review]
Fix - v1

works fine and looks good; r=dbo
Attachment #333138 - Flags: review?(daniel.boelzle) → review+
Whiteboard: [patch in hand] [needs-review] → [patch in hand]
Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: [patch in hand]
Target Milestone: --- → 0.9
Checked in lightning build 2008081121 and sunbird 20080811 -> VERIFIED
Status: RESOLVED → VERIFIED
This issue still occurs when deleting an event from the Find Events pane.
Tested with Lightning pre-0.9 build 2008081819.
Do you use the very recent nightly? There has been a fix using the DEL key in bug 449573.
I was using yesterday's build.  Today's build is fine.  Great!  Thanks!
You need to log in before you can comment on or make changes to this bug.