445521 - add check for liblocation-dev on maemo

Status: RESOLVED INCOMPLETE

(Core :: DOM: Geolocation, defect)

Description

[Doug Turner (:dougt)]

because of:

https://bugzilla.mozilla.org/show_bug.cgi?id=437948#c13

Some setups (well stuart does!) run into:

stuart: In file included from /home/pavlov/dep/mozilla-central/dom/src/geolocation/nsGeolocation.cpp:52:
[09:00am] stuart: /home/pavlov/dep/mozilla-central/dom/src/geolocation/MaemoLocationProvider.h: At global scope:
[09:00am] stuart: /home/pavlov/dep/mozilla-central/dom/src/geolocation/MaemoLocationProvider.h:71: error: 'gpsbt_t' does not name a type

The work around is via documention here:

http://wiki.mozilla.org/Mobile/Build/cs2007q3

But it would be good to have a configure test.

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: configure fails without liblocation on hildon build

This just fails if liblocation doesn't exist and NS_HILDON is defined.

Doug, you might want to use NS_HILDONLOCATION_CFLAGS and NS_HILDONLOCATION_LIBS in your make files.

Also, should we be enabling this location providers with a mozconfig ac option?

Comment 2

[Oleg Romashin (:romaxa)]

I think HILDON_ prefix is bad for location API... hildon - it is just additional API layer for UI.

I guess better Define is NS_MAEMO_LOCATION...

But for location libs and cflags it is better to use general DEFINE like MOZ_LOCATION_LIBS/CFLAGS which will be defined in configure script according to platform building environment.

Comment 3

[Doug Turner (:dougt)]

Comment on attachment 330217 [details] [diff] [review]
configure fails without liblocation on hildon build

i do not want a seperate flag to indicate use-location.  If you want, have the OSSO try to find liblocation, and if it isn't there error out.

Comment 4

[Doug Turner (:dougt)]

-> blassey, since he started hacking on it.

Comment 5

[Doug Turner (:dougt)]

what do we want to do here?

romaxa, the current stuff in m-c is not defining NS_MAEMO_LOCATION for me.  but it sounds like it is working for you...  Any ideas?

Comment 6

[Doug Turner (:dougt)]

the build bustage will be fixed in 478923, and by ensuring that the libhildon1-dev package is installed which is part of the maemo sdk.