Rearrange LIR opcodes, make room for LIR_div.

VERIFIED WONTFIX

Status

VERIFIED WONTFIX
11 years ago
9 years ago

People

(Reporter: gal, Assigned: gal)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
Make more room for additional arithmetic opcodes and move callh out of the way for LIR_div.
(Assignee)

Comment 1

11 years ago
Created attachment 329930 [details] [diff] [review]
Reshuffle LIR_ops.

Mason, can you please sandbox this and then assign the bug back to me? Thanks.
(Assignee)

Updated

11 years ago
Assignee: nobody → mason.chang
(Assignee)

Comment 2

11 years ago
Whats the status of this bug?

Comment 3

11 years ago
Does not pass any string tests on the build. Errors such as:

ecma3/String/e15_5_4_12_5.abc : var s = new String( String.fromCharCode(1339) ); s.toUpperCase().charCodeAt(0) = 1339 FAILED! expected: undefined
  ecma3/String/e15_5_4_12_5.abc : var s = new String( String.fromCharCode(1340) ); s.toUpperCase().charCodeAt(0) = 1340 FAILED! expected: undefined
  ecma3/String/e15_5_4_12_5.abc : var s = new String( String.fromCharCode(1341) ); s.toUpperCase().charCodeAt(0) = 1341 FAILED! expected: undefined
  ecma3/String/e15_5_4_12_5.abc : var s = new String( String.fromCharCode(1342) ); s.toUpperCase().charCodeAt(0) = 1342 FAILED! expected: undefined
  ecma3/String/e15_5_4_12_5.abc : var s = new String( String.fromCharCode(1343) ); s.toUpperCase().charCodeAt(0) = 1343 FAILED! expected: undefined
  ecma3/String/e15_5_4_12_5.abc : var s = new String( String.fromCharCode(1344) ); s.toUpperCase().charCodeAt(0) = 1344 FAILED! expected: undefined


Also, a compile then ./avmshell gets the following error.
espresso:shell masonchang$ ./avmshell 
Assertion failed: "((operandCount[v]==2))" ("/Users/masonchang/Documents/workspace/tamarin-sandbox/nanojit/LIR.cpp":1644)
AvmAssert failed: 0 (/Users/masonchang/Documents/workspace/tamarin-sandbox/nanojit/LIR.cpp:1644)

Assignee: mason.chang → gal
(Assignee)

Comment 4

11 years ago
Ah, I guess I have to reshuffle the operand table as well. And the name table probably too. Mhm. Ok, I will whip up a new patch. Taking the bug back from Mason.
(Assignee)

Updated

10 years ago
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → WONTFIX

Updated

9 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.