445709 - A patch which corrects some affiliate links. Needs reviewing.

Status: VERIFIED FIXED

(Websites Graveyard :: spreadfirefox.com, defect, P1)

Description

[Paul Booker]

Attachment: sfx_affiliates.module patch

Please review this patch which corrects a number of affiliate links

Comment 1

[Chris Pollett]

Comment on attachment 329985 [details] [diff] [review]
sfx_affiliates.module patch

Hmm. I am getting the feeling I am reviewing patches which do almost the same thing. As with 447596 please change <br> to <br /> otherwise looks good.

Comment 2

[Paul Booker]

Sending        sfx_affiliates/sfx_affiliates.module
Transmitting file data .
Committed revision 17370.

I can't see those changes on stage that should be present immediately without clearing the drupal cache (it's been over 15 minutes)

Would you please confirm that SVN is being checked out to stage @ https://spreadfirefox.authstage.mozilla.com

Thanks, Paul

Comment 3

[Alex Polvi]

Paul - did your updates appear?

Comment 4

[Paul Booker]

@Alex 

I can't see the change ..

+	  'title' => t('Welcome to the Affiliate Program!')

The other changes i will not be able to see until the cron page is run to regenerate the affiliate blocks with fresh content.

Comment 5

[Alix Franquet [:alix]]

Paul/Juliana: shouldn't it say Affiliates instead of Affiliate?

Comment 6

[Juliana]

(In reply to comment #5)
> Paul/Juliana: shouldn't it say Affiliates instead of Affiliate?
> 

Yes, we're trying to use "Affiliates" consistently throughout the program.

Comment 7

[Paul Booker]

Can we please push the latest revision of the sfx_affiliates.module to production..

http://viewvc.svn.mozilla.org/vc/projects/spreadfirefox.com/trunk/modules/sfx/sfx_affiliates/sfx_affiliates.module?revision=17555&view=markup

Comment 8

[Alex Buchanan [:abuchanan]]

patch was committed to trunk in r17555 by paul

http://viewvc.svn.mozilla.org/vc?view=rev&revision=17555

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://spreadfirefox.authstage.mozilla.com/affiliates/homepage