445719 - ByteArray float and double operations are busted

Status: VERIFIED WONTFIX

(Tamarin Graveyard :: Tracing Virtual Machine, defect)

Description

[Edwin Smith]

from Scott Peterson:

I found a couple of bugs that were causing Lua and Scimark trouble.
 
In ByteArray.cpp, the double and float variants of the _read/_write native functions were calling getData() instead of getData(offset).  This may not be a huge deal but I noticed it before I found the real culprit.  An assertion in getData() would have caught this had it not been commented out.
 
In ByteArray.as, readDouble and readFloat don't return anything!  They both need a "return d" at the end.

Comment 1

[Edwin Smith]

test case fodder

var ba:ByteArray = new ByteArray;
ba.writeDouble(123);
ba.position = 0;
ba.readDouble(); // returns NaN
ba.position = 0;
ba.writeFloat(123);
ba.position = 0;
ba.readFloat(); // returns NaN