44572 - Delete doesn't enable in some cases using Next Unread.

Status: VERIFIED DUPLICATE of bug 84260

(SeaMonkey :: MailNews: Message Display, defect, P3)

Description

[laurel]

Using july 5 commercial build
Seen using NT 4.0 and linux rh6.0
Haven't tried mac yet

Delete is often not enabling when landing on a message via Next Unread after
having switched folders or when first launching mail, logging into mail account
and using Next to read new messages in inbox.

1.  Launch IMAP profile to mail which you know will have some new messages in
the inbox. 
2.  Select INBOX if not already autoselected and provide proper login password.
3.  Let folder finish loading, notice the Delete button is disabled.
4.  Click Next (Unread) button. Lands you on the next unread message, message
loads in message pane.  Notice the delete button is still disabled, can't use it
to delete.  The button will stay disabled until you manually select a message in
the thread pane or may clear if switching folders.

Note:  Same thing occurs frequently when switching among folders and using Next
within a newly selected folder.

Result:  Delete button stays disabled until you select thread ("manually") in
thread pane.

Comment 1

[scottputterman]

I see this too. Moving to M18 and nominating for beta3.

Comment 2

[lchiang]

+ per mail triage

Comment 3

[scottputterman]

reassigning to varada.  This is actually a focus bug.  It's not enabling because
focus is on the folder pane and the inbox is selected. If you were on another
folder and hit delete then it would try to delete the folder. We need to get
focus on the thread pane.

Comment 4

[scottputterman]

adding myself to cc list.

Comment 5

[lchiang]

second pass: - per mail triage

Comment 6

[scottputterman]

removing mail2 keyword.

Comment 7

[varada]

Re-assigning bug to sspitzer as per putterman.

Comment 8

[(not reading, please use [e-mail] instead)]

clearing milestone, m17 and m18 are meaningless now.  these need to be triages
along with the rest.

Comment 9

[Asa Dotzler [:asa]]

This works fine for me in 030608 mozilla linux build.  I followed laurel's steps
exactly and Delete was enabled.  Laurel, are you still seeing this?

Comment 10

[rcoyle]

Deleting is horrible still.  I tried to delete 156 mail docs from my inbox.  It
took 4 attempts.  The screen flickered and flashed and many docs. were still
left in my inbox and I had to do it over and over again until they were gone. 
Main is our most important use of this application and I hope it is fixed before
the next beta.

Comment 11

[jag (Peter Annema)]

Asa: I see this, and can reproduce it with the original steps 100%. I was going
to file a bug on it if I hadn't found this. And indeed, it is a focus issue.
When the box is selected (e.g. by clicking on it), and you then press N, along
with the message header mechanically being selected and the message displayed if
the message pane is open, focus should shift to the message pane (IMO) or
alternatively the header pane. This should enable the delete button /
accelerator key.

[e-mail], I believe what you are seeing is a different bug which
was fixed a while back (I haven't seen it for a long time, that is).

Comment 12

[Mike Gratton]

I don't think it's completely a focus problem. Note that the thread pane *does*
get the focus after clicking on a mailbox (which makes it sucky to navigate the
folder hierachy by keyboard - maybe that should be filed as a bug).

The bug is still reproducable, but only if you use keyboard navigation -
pressing "N" or "F" after selecting a folder will do it. The problem does not
occur if you click on the "Next" button. Interestingly, you can still delete the
message using the keyboard, even though the Delete button is disabled.

Given it's only a problem when using the keyboard, shouldn't this have the
keyword "access"?
I'll look into the bug further.

Comment 13

[Mike Gratton]

The problem with this is nsMsgDBView::GetCommandStatus() is incorrectly
returning false when called by DefaultController.isCommandEnabled() in
mail3PaneWindowCommands.js (and possibly by others)

Interestingly, fixing bug 97134 fixes this, so either something is broken in
nsUInt32Array or nsMsgDBView::GetSelectedIndices().

I'll look further into precisely which of those two are broken.

Comment 14

[Mike Gratton]

Adding myself to the CC list, aplogies for the spam.

Comment 15

[Mike Gratton]

The root cause of the problem is the outliner's over-anxious key event handlers.
Pressing a key causes the thread outliner to select a non-existing row. This
error the propagates up to nsMsgDBView::GetCommandStatus() via
nsMsgDBView::GetSelectedIndices().

Fixing the outliner's handler (bug 97421) fixes this bug.

Comment 16

[Greg K.]

This may be a related problem. The following was tested under Mac/0.9.3 and
Mac/2001090508.

1. Select an IMAP folder with one and only one message inside
2. Observe focus is now on message pane
3. Select All using the keyboard (Cmd- or Ctrl-a)
4. Observe that the message is selected but the Delete button is not enabled

This only occurs if there is one and only one message in the folder. Deselecting
the selected message and reselecting all using the keyboard causes the Delete
button to enable.

Choosing Select All from the menu does always cause the Delete button to enable.

What do you think? Is this part of this bug, or should I open a new one?

(Propose that this bug is All/All.)

Comment 17

[Mike Gratton]

It looks like the same problem - any way you can cause a single message to be
selected after selecting a folder using keystrokes will reproduce this behaviour.

Comment 18

[Mike Gratton]

Blocked by bug 97421

Comment 19

[Mike Gratton]

This has been fixed in bug 84260.

Comment 20

[laurel]

*** Bug 113937 has been marked as a duplicate of this bug. ***

Comment 21

[David :Bienvenu]

dup

*** This bug has been marked as a duplicate of 84260 ***

Comment 22

[Dawn Endico]

this is a dup of a fixed bug. removing item for this bug from release notes.

Comment 23

[Sheela Ravindran]

verified as dup.