44574 - Menu item Search All Mail implies we can't search news.

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P3)

Description

[laurel]

Since we're doing Search Messages to include newsgroup messages, I think we
should change the menu item back to a generic "Search Messages" or something
like it.

Logging this bug to track decision.

Comment 1

[jglick]

Reassign bug to Sol. Sol, please reassign to John Gable if you feel that is 
appropriate.

From email 6/30/00:

Jennifer Glick wrote:
>If we do search News as well as Mail, I agree that "Search Messages" is more 
acurate.
>I think John Gable owns the naming of this item though.  John?  Sol, do you now 
if we can get this item globally changed?


Alec Flett wrote:
>yes, I like that both because it's more generic, and because it matches 4.x


Laurel Carlson wrote:
> Since we do search news messages, the Search All Mail menu item is a little 
>misleading.  Should we change it to include news, or maybe go back to the old  
>generic "search messages"?

Comment 2

[simone]

I agree - in fact, I've already written the help content to say Search 
Messages. :-)

Comment 3

[sol]

Hmmm - I think we want consistency between the item that is shown in Navigator, 
and the item shown in Mail, so the wording needs to work for both contexts. 
Note: we are going to allow an end user to initiate an email/newsgroup message 
search from Navigator.

"Search Messages" works in Mail, but if you're in Navigator and you go under the 
Search menu and see "Search Messages", the lack of context may be confusing.

Does "Search Mail/News Messages" work for people? Jennifer (and Laurel and Alec) 
- can you let me know what you think?

Note that this proposed label is no longer than some of the items in the Search 
menu (e.g., "Search Bookmarks/History"), and is a description that has meaning 
when the end user is in Navigator.

Also, if this proposal is OK, can someone please tell me who to reassign this 
bug to.

Comment 4

[laurel]

Search Mail/News Messages sounds OK to me, Sol.

Comment 5

[scottputterman]

It sounds ok to me too.  I'll reassign to alecf since we have to remove the '.'
before the menu item anyway.

Comment 6

[jglick]

Sounds good to me. Simone, you ok with that?  "Search Mail/News Messages" or 
"Search Mail/News"?

Comment 7

[simone]

I prefer "Search Mail/News Messages"

Comment 8

[Jay Patel [:jay]]

Putting on [nsbeta2-] radar. Not critical to beta2. 

Comment 9

[johng]

nsbeta3 nominee so we don't forget this change.

Comment 10

[laurel]

Using july 13 commercial build, menu item now reads "Search Mail/News Messages".
since this was the agreed upon text, I'm marking fixed/verified.

Comment 11

[laurel]

.

Comment 12

[Alec Flett]

this went in with timeless's contribution yesterday.. but it still says Search
all Mail in navigator... I'm tempted to reopen..anyone care?

Comment 13

[laurel]

Reopened. Sorry, forgot about the browser menu.

Comment 14

[timeless]

Ok so i missed a spot. I'll get alecf to push that one through w/ my next patch.

Comment 15

[timeless]

Mass accepting.

Comment 16

[robinf]

Adding myself to cc: list.

Comment 17

[selmer (gone)]

Putterman fixed this, please test.

Comment 18

[laurel]

With aug18 commercial build, the search mail menu in mail windows is correct. It
is worded "Search Mail/News Messages".  Since the mail window is fine, I'm
removing bug 44139 and bug 44873 from the bug blocks field. Nbaca's mail menu
issues with this should be fine.

However, the browser menu still shows "Search Mail", which is the reason this
bug was left open.  And another However, is bug #46444 which is to address the
fact the browser menu item is not enabled. 46444 has been futured, although I
really think we should remove it if we're not going to enabled it. 

putterman -- Please answer:
1) Do you want this bug reopened to track the menu wording issue for the browser
window or log a new one (or just forget about it!)?
2) For 46444 will we leave the disabled menu item in, or will we remove it?

Comment 19

[laurel]

OK using 2000-08-17-13  commercial build linux rh6.0, 2000-08-17-08 commercial
build mac OS 9.0 and NT 4.0

Comment 20

[laurel]

To clarify, menu item was removed.