Closed Bug 445745 Opened 14 years ago Closed 14 years ago

Building without MATHML fails after landing 436083

Categories

(Core :: Layout, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.1a1

People

(Reporter: romaxa, Assigned: romaxa)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Build fix (obsolete) — Splinter Review
#ifdef MOZ_MATHML
...........
 GK_ATOM(matrixrow_, "matrixrow")
+GK_ATOM(maximum_scale, "maximum-scale")


nsContentUtils.cpp:4262: error: `maximum_scale' is not a member of `nsGkAtoms'
Your patch includes the removal of a bunch of files.  Is that intentional?
Attached patch Updated patchSplinter Review
I think it would be better to remove them also... but probably in some other bug...
Attachment #330024 - Attachment is obsolete: true
Could you please request review and get this in? This bug breaks the default Thunderbird build, which has MathML disabled.
Comment on attachment 330073 [details] [diff] [review]
Updated patch

Patch is trivial -- bholley, does this look right to you?  And sicking, can you SR this so it can be checked in?
Attachment #330073 - Flags: superreview?(jonas)
Attachment #330073 - Flags: review?(bholley)
Comment on attachment 330073 [details] [diff] [review]
Updated patch

yep - my bad. I didn't see that that section was inside an ifdef. r=bholley

Thanks dholbert.
Attachment #330073 - Flags: review?(bholley) → review+
Assignee: nobody → romaxa
Attachment #330073 - Flags: superreview?(jonas) → superreview+
Pushed as changeset a3449a66f7ad
http://hg.mozilla.org/mozilla-central/index.cgi/rev/a3449a66f7ad
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Keywords: checkin-needed
Target Milestone: --- → mozilla1.9.1a1
You need to log in before you can comment on or make changes to this bug.