Building without MATHML fails after landing 436083

RESOLVED FIXED in mozilla1.9.1a1

Status

()

Core
Layout
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

Trunk
mozilla1.9.1a1
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

1.53 KB, patch
Bobby Holley (On Leave Until June 11th)
: review+
sicking
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

10 years ago
Created attachment 330024 [details] [diff] [review]
Build fix

#ifdef MOZ_MATHML
...........
 GK_ATOM(matrixrow_, "matrixrow")
+GK_ATOM(maximum_scale, "maximum-scale")


nsContentUtils.cpp:4262: error: `maximum_scale' is not a member of `nsGkAtoms'

Comment 1

10 years ago
Your patch includes the removal of a bunch of files.  Is that intentional?
(Assignee)

Comment 2

10 years ago
Created attachment 330073 [details] [diff] [review]
Updated patch

I think it would be better to remove them also... but probably in some other bug...
Attachment #330024 - Attachment is obsolete: true

Comment 3

10 years ago
Could you please request review and get this in? This bug breaks the default Thunderbird build, which has MathML disabled.
Comment on attachment 330073 [details] [diff] [review]
Updated patch

Patch is trivial -- bholley, does this look right to you?  And sicking, can you SR this so it can be checked in?
Attachment #330073 - Flags: superreview?(jonas)
Attachment #330073 - Flags: review?(bholley)
Comment on attachment 330073 [details] [diff] [review]
Updated patch

yep - my bad. I didn't see that that section was inside an ifdef. r=bholley

Thanks dholbert.
Attachment #330073 - Flags: review?(bholley) → review+
Assignee: nobody → romaxa
Attachment #330073 - Flags: superreview?(jonas) → superreview+
Keywords: checkin-needed
Pushed as changeset a3449a66f7ad
http://hg.mozilla.org/mozilla-central/index.cgi/rev/a3449a66f7ad
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Keywords: checkin-needed
Target Milestone: --- → mozilla1.9.1a1
You need to log in before you can comment on or make changes to this bug.