Multiple tests with the same class names confuse automatic rewriting

RESOLVED FIXED in mozilla1.9.1a2

Status

()

Core
General
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Benjamin Smedberg, Assigned: Benjamin Smedberg)

Tracking

unspecified
mozilla1.9.1a2
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 330108 [details] [diff] [review]
Make some tests use namespaces, rev. 1

In at least one of the XPCOMGC rewrites we are using "global" analysis to determine which classes are instantiated. This analysis is being confused by multiple tests that have class types with the same name.

This is easy enough to fix by using namespaces, which I believe are now ancient enough that all our compilers support them. Asking biesi for review since these are mostly in necko.
Attachment #330108 - Flags: review?(cbiesinger)
Comment on attachment 330108 [details] [diff] [review]
Make some tests use namespaces, rev. 1

+++ b/netwerk/test/TestProtocols.cpp
+} // namespace
+using namespace TestProtocols;

should probably put an empty line in here
Attachment #330108 - Flags: review?(cbiesinger) → review+
(Assignee)

Comment 2

10 years ago
Pushed to mozilla-central: http://hg.mozilla.org/mozilla-central/index.cgi/rev/6b425f9adc30
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1a2
You need to log in before you can comment on or make changes to this bug.