44592 - Search UI: polish items needed

Status: VERIFIED WORKSFORME

(SeaMonkey :: MailNews: Message Display, defect, P2)

Description

[laurel]

Search messages spec: http://gooey/client/5.0/specs/mail/Search/Search.html

This bug is intended to track UI polish items (such as dialog layout, alignment)
needed for the 6.0 release timeframe.  
Issues which have some functionality implications should be logged as separate
issues.

If you add an item, please number it for easier reference to make an overall
list of items to do.

1.   Seamonkey Search Spec shows results pane as having an outline and heading
of "Results". As of july5 build, dialog shows only outliner in the
criteria/"Conditions" section but not in the results pane.  (For comparison, 4.x
didn't use these outliners/headings in either section of the search ui.)
2.   Need better alignment and proportions of criteria section to results pane.
Spec shows outliner to include the righthand buttons -- currently the outline in
criteria section doesn't include the buttons which makes it even worse
aesthetically.

Comment 1

[jglick]

Laurel, thanks for starting this bug. In the UE Review meeting we have been 
having, the following items have also been identified and given priorities. 
(P1-highest, P5-lowest)

1. Change "Reset" button to "Clear" for consistency with Filters and Subscribe 
dialogs. (P3)
2. "Conditions" and "Results" should be bolded. (P3)
3. "Results" area needs a group box (similar to "Conditions") around it. Should 
be aligned with the "Conditions" box. (P2.5)
4. IF "OR" radio button selected: The first Condition item should say "the" not 
"or the". Additional conditions should say "or the".(P3)
5. If "AND" radio button selected: The first Condition item should say "the" not 
"and...".  Additional conditions should say "and the". (P3)
6. Remove the "." from the menu item.
7. When the dialog first opens, the Results area shouldn't be visible OR (if 
that is not possible) a reasonable amount of the Results area should be visible 
when the window first opens. (Currently the window opens with just the column 
headers of the Results area visible). (P2)
8. "Search for itmes in:" menu should always have a default account (the account 
that was selected when the user opened the dialog or the default account if no 
account was selected). (P3)
9. Top of the "Search" button should be moved down so it aligns with the top of 
the Conditions box. (P4)
10. Descriptive text in the Conditions box needs to be changed (currently using 
the Filters text) to "Search for messages which:". (P1)
11. "Search Subfolders" should be checked as the default.
12. Dialog mnemonics (P5)
13. Results area - need to add "Open" button. (P2)
14. Column headers - Need to add a "Location" column header (displays the parent 
folder only, not the path). (P1)
15. Default columns (and order)should be: Thread, Subject, Sender, Date, 
Location, Column Widget (P2)
16. "Search for items in:" should be centered aligned with its associated menu. 
(P5)

Comment 2

[scottputterman]

Mail triage is marking nsbeta3-

Comment 3

[jglick]

Taking bug.

Comment 4

[hangas]

Marking nsbeta3+ for 3,7,9 only since jglick has these in local tree and looking 
good.

Comment 5

[hangas]

Removing nsbeta3+ and nomination for nsbeta3.  Parts of this bug have been fixed. 
Tonight 3,7,9 were fixed by jglick and checked in by hewitt.  Sending bug back to 
putterman for the remaining work.

Comment 6

[hangas]

Number 11 was fixed too!

Comment 7

[jglick]

Update status of this bug:

*1. Still open
 2. Invalid. No other windows have this so this would be inconsistent.
 3. Fixed
*4. Still open
*5. Still open
 6. Fixed
 7. Fixed
 8. Fixed
 9. Fixed
 10. Fixed
 11. Fixed
*12. Still open
*13. Still open
*14. Still open
*15. Still open
 16. Fixed

Comment 8

[jglick]

I also moved the "Close" button to the bottom of the dialog instead of below the 
"Reset" button.

Comment 9

[scottputterman]

It looks like someone forgot to check in results.label into the dtd file.  The 
search dialog won't come up for me today.

Comment 10

[jglick]

yes, 'someone' messed up. :-(

This has been fixed thanks to scott's help.

Item #1 has also been fixed.

Comment 11

[Alec Flett]

During this nsbeta3+/rtm period, someone from the mail team needs to be the 
reviewer for all changes (XUL included) to mailnews, plus a super-reviewer 
(myself or mscott)

Comment 12

[jglick]

Remaining Issues are:

1. IF "OR" radio button selected: The first Condition item should say "the" not 
"or the". Additional conditions should say "or the".
2. If "AND" radio button selected: The first Condition item should say "the" not 
"and...".  Additional conditions should say "and the".
3. Dialog mnemonics.
4. Results area - need to add "Open" button.
5. Column headers - Need to add a "Location" column header (displays the parent 
folder only, not the path). 
6. Default columns (and order)should be: Thread, Subject, Sender, Date, 
Location, Column Widget.

Comment 13

[jglick]

Add mail3 keyword so bug considered for 6.5

Comment 14

[scottputterman]

reassigning to gayatrib

Comment 15

[jglick]

#4 covered in bug 44344
#5 and #6 covered in bug 44341

Comment 16

[scottputterman]

of the remaining items, the first 3 get the nsbeta1- and the last 3 are part of
other bugs that have been nsbeta1+'d

Comment 17

[jglick]

UPDATE

1. If "OR" radio button selected: The first Condition item should say "the". 
Additional conditions should say "or the".
2. If "AND" radio button selected: The first Condition item should say "the".  
Additional conditions should say "and the".
3. Dialog mnemonics.

Comment 18

[scottputterman]

reassigning to naving

Comment 19

[jglick]

Items 1 and 2 are bug: 82015

Comment 20

[jglick]

Last item, 3, is covered in bug 68899.  Marking this Works for me, since 
remaining issues covered in other bugs.

Comment 21

[laurel]

Marking verified worksforme. Other bugs to take over.