Closed Bug 445993 Opened 14 years ago Closed 14 years ago
following a target="_blank" in fennec opens a new window but does not load the target url
Right now if you follow an href that includes a target="_blank" a new toplevel window is opened but the target url is not loaded into that new window. Probably depends on the new multiple document/tabs impl for fennec.
I suspect we're getting the arguments passed to our window, but not doing anything with it. Looks like this code: http://mxr.mozilla.org/mobile-browser/source/chrome/content/browser.js#120 is bottoming out since a newly opened window won't be passing in nsICommandLine arguments
This patch cleans up the commandline handling. We now do nothing if the window wasn't given an nsICommandLine via the window.arguments. This is an indication the window is an initial window. All other window opens are secondary and we shouldn't try to load a default page. I also added the "url" flag Firefox uses for various tools as well.
Assignee: nobody → mark.finkle
Status: NEW → ASSIGNED
Attachment #330618 - Flags: review?(gavin.sharp)
Comment on attachment 330618 [details] [diff] [review] Cleanup the commandline handling Why do we need the timeout, anyways?
Attachment #330618 - Flags: review?(gavin.sharp) → review+
changeset: 72:e93de367265f tag: tip user: Mark Finkle <email@example.com> date: Mon Jul 21 17:00:55 2008 -0400 summary: b=445993, r=gavin. target=_blank doesn't load the URL changeset: 73:5fb797de3639 tag: tip user: Mark Finkle <firstname.lastname@example.org> date: Mon Jul 21 17:12:47 2008 -0400 summary: b=445993, r=gavin. followup to remove unneeded setTimeout
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
verified with 20091106 1.9.2 nightly on my n810 with http://people.mozilla.org/~jmaher/target.html
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.