44608 - Need to add nsIWebBrowserChrome::ExitModalEventLoop()

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: APIs, defect, P3)

Description

[vidur (gone)]

Currently, we bring up modal windows by calling 
nsIDocShellTreeOwner::ShowModal()/nsIWebBrowserChrome::ShowAsModal(). The 
expectation is that the implementation of these methods will spin a nested event 
loop while the modal window is up. We only break out of the event loop when the 
window itself is destroyed. Based on discussions in the API review meeting, we 
decided to add nsIDocShellTreeOwner::ExitModalLoop() and 
nsIWebBrowserChrome::ExitModalEventLoop() methods to allow the browser component 
to programmatically exit the event loop, providing a status code to be passed 
back to the caller of ShowModal() in the case of an error.

Comment 1

[vidur (gone)]

I have a fix that's been reviewed by rpotts. It's safe since it 
doesn't change existing codepaths. Nominating for nsbeta2 since it's a safe fix 
and helps us drive to API completion.

Comment 2

[Jay Patel [:jay]]

Putting on [nsbeta2+] radar for beta2 fix. 

Comment 3

[vidur (gone)]

Fix checked in on 7/12/2000.

Comment 4

[Syd Logan]

Vidur stated a fix was checked in. Marking this fixed.

Comment 5

[John Morrison]

verified fixed (er, checked in)