446089 - expose some osso context functionality

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Doug Turner (:dougt)]

we need to expose the osso_context returned after a successful call to osso_initialize() so that other parts of mozilla can make use of other libosso functions.

the initial customer of this will be the idle service which, on desktop linux, uses the x screen saver (xss).  The xss doesn't ship with osso devices, so we can't depend on it for figuring out idle time.  libosso does provide a hook to discover idle time however, needs the osso_context.  There is no global osso_context or function that gives you the right context. Hence, we need to expose it somehow.  (see bug 445267 for the idle service details.).

Comment 1

[Doug Turner (:dougt)]

hmm.  i am thinking we shouldn't expose the context unless we have to.  For now, lets just catch and broadcast the events that are related to the osso_context (OOM, idle, and shutdown)

Comment 2

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 3

[Doug Turner (:dougt)]

Comment on attachment 330954 [details] [diff] [review]
patch v.1

stuart mentioned i should change ns_literal_string for L""

Comment 4

[Doug Turner (:dougt)]

Attachment: patch v.2

detects hw changes and forward the appropriate notification.

Comment 5

[Doug Turner (:dougt)]

Comment on attachment 331241 [details]
patch v.2

wrong patch.

Comment 6

[Doug Turner (:dougt)]

Attachment: patch v.2

Comment 7

[Stuart Parmenter]

Comment on attachment 331242 [details] [diff] [review]
patch v.2

 NS_LITERAL_STRING("low-memory").get()

should be L"low-memory"

why must state and ourState both be memory_low_ind in order to fire the memory pressure notification?  add some comments

Comment 8

[Doug Turner (:dougt)]

using L"" results in:

/home/dougt/builds/mozilla/src/toolkit/xre/nsNativeAppSupportUnix.cpp:234: error: no matching function for call to 'nsDerivedSafe<nsIObserverService>::NotifyObservers(int, const char [16], const wchar_t [11])'


I could cast it away, but not sure of the harm of using the literal string class.

Comment 9

[Doug Turner (:dougt)]

Attachment: patch v.2 w/ comment

Comment 10

[Doug Turner (:dougt)]

33d9196aa5d5

Fixed.