Closed
Bug 446190
Opened 16 years ago
Closed 16 years ago
alarm service should mind disabled calendars
Categories
(Calendar :: Alarms, defect)
Calendar
Alarms
Tracking
(Not tracked)
VERIFIED
FIXED
0.9
People
(Reporter: dbo, Assigned: dbo)
Details
Attachments
(2 files)
4.01 KB,
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
9.78 KB,
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
I spotted that the alarm service triggers getItems calls (thru timer callback), even though the calendar is disabled.
Assignee | ||
Comment 1•16 years ago
|
||
Assignee: nobody → daniel.boelzle
Status: NEW → ASSIGNED
Attachment #330385 -
Flags: review?(philipp)
Comment 2•16 years ago
|
||
Comment on attachment 330385 [details] [diff] [review] fix r=philipp
Attachment #330385 -
Flags: review?(philipp) → review+
Assignee | ||
Comment 3•16 years ago
|
||
Checked in on HEAD and MOZILLA_1_8_BRANCH => FIXED.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.9
Comment 4•16 years ago
|
||
I checked this issue in build 2008072318, and it is possible to reproduce this bug. I fear the patch doesn't work as expected -> REOPEN
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 5•16 years ago
|
||
This flushes the timers of a calendar, too. I think this bug could also be triggered by removing a calendar. It seems the timers have been dangling in that case, too. BTW: Auto snooze on shutdown confused me once again (I thought I regressed something, because my alarms didn't came up again after restart). I am still not convinced by that concept and doubt I am the only one.
Attachment #331305 -
Flags: review?(philipp)
Comment 6•16 years ago
|
||
Comment on attachment 331305 [details] [diff] [review] more fixes > onLoad: function co_onLoad(calendar) { > // ignore any onLoad events until initial getItems() call of startup has finished: > if (calendar && this.alarmService.mLoadedCalendars[calendar.id]) { >- // onLoad signals that changes to the item set are unknown, so purge out all >- // alarms belonging to the refreshed/loaded calendar: >- this.alarmService.notifyObservers("onRemoveAlarmsByCalendar", [calendar]); Why is this not needed anymore? r=philipp
Attachment #331305 -
Flags: review?(philipp) → review+
Assignee | ||
Comment 7•16 years ago
|
||
Because it's been shifted to initAlarms().
Assignee | ||
Comment 8•16 years ago
|
||
Fixed another typo and checked in on HEAD and MOZILLA_1_8_BRANCH => FIXED.
Status: REOPENED → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → FIXED
Comment 9•16 years ago
|
||
Checked in lightning build 2008080603 and sunbird 20080805 -> VERIFIED
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•