446209 - CTRL-TAB should not persist right-click menu on webpage when switching URLs

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Tony Chung [:tchung]]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1a1pre) Gecko/2008071806 Minefield/3.1a1pre
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1a1pre) Gecko/2008071806 Minefield/3.1a1pre

If you right-click for a menu on a url, and then CTRL-TAB to another url, the right-click menu persists over to the new window.   We should hide the right-click menu for that open page, as soon as CTRL-tab menu is activated.

Reproducible: Always

Steps to Reproduce:
1. download 3.1a1 nightly
2. open a few tabs
3. on any url, right-click an area to pop up the context menu (eg. bugzilla page)
4. CTRL-TAB to open the thumbnail strips, and tab to another website
5. Verify the new page opens, but the right-click context menu from last page still persisted.
Actual Results:  
Right-click menu persisted on another page

Expected Results:  
Right-click menu should dissapear as soon as you enter CTRL-TAB menu.

Comment 1

[Dão Gottwald [:dao]]

Attachment: patch

This is now consistent with how the tabbox handles the key events.

Comment 2

[Dão Gottwald [:dao]]

http://hg.mozilla.org/index.cgi/mozilla-central/rev/3d083d9418dc

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Dao, if the context menu was opened before I have to hit Ctrl+Tab twice to get the Ctrl-Tab panel. Shouldn't this be done in one step? 

Comment 4

[Dão Gottwald [:dao]]

Probably yes, but neither bug 395980 nor this one changed that. Disabling the panel should give you the same result.

Comment 5

[Tony Chung [:tchung]]

Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1a2pre) Gecko/20080815020705 Minefield/3.1a2pre.  

however, this is still broken if CTRL-TAB extension is installed from amo.  Opened Bug 450813 to track that issue.