446229 - SM: fixing GCC conversion warnings

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Igor Bukanov]

+++ This bug was initially created as a clone of Bug #441686 +++

Currently when compiling SM sources under GCC 4.2 woth -Wconversion enabled (browser builds) the compiler generates warnings like:

NULL used in arithmetic
converting to non-pointer type ‘long int’ from NULL
deprecated conversion from string constant to ‘char*’

It would be nice to fix this.

Comment 1

[Igor Bukanov]

Attachment: v1

To make things clear instead of changing the code like in:

-        STOBJ_SET_PARENT(FUN_OBJECT(fun), NULL);
+        STOBJ_SET_PARENT(FUN_OBJECT(fun), 0);

I added *OBJ_CLEAR_(PROTO|PARENT) functions with usage like in:

-        STOBJ_SET_PARENT(FUN_OBJECT(fun), NULL);
+        STOBJ_CLEAR_PARENT(FUN_OBJECT(fun));

An alternative is to name the functions *OBJ_NULL_(PROTO|PARENT), but that may not sound good.

Comment 2

[Brendan Eich [:brendan]]

Comment on attachment 330430 [details] [diff] [review]
v1

Great, thanks!

/be

Comment 3

[Igor Bukanov]

fixed - http://hg.mozilla.org/mozilla-central/index.cgi/rev/f2b76fc67c3b