Open Bug 446272 Opened 16 years ago Updated 2 years ago

Automate litmus test Testcase ID #5007 - Keep downloads in their current position when resuming bottom-most download

Categories

(Toolkit :: Downloads API, defect)

defect

Tracking

()

People

(Reporter: poonaatsoc, Unassigned)

References

()

Details

Attachments

(1 file, 1 obsolete file)

Proposed type of test: chrome

Proposed location of test: toolkit/mozapps/downloads/tests/chrome
Attached patch v1.0 (obsolete) — Splinter Review
The test passes.
Attachment #330925 - Flags: review?(sdwilsh)
Attached patch v2.0Splinter Review
Test updated to accommodate the new
Attachment #330925 - Attachment is obsolete: true
Attachment #331494 - Flags: review?(sdwilsh)
Attachment #330925 - Flags: review?(sdwilsh)
Product: Firefox → Toolkit
Comment on attachment 331494 [details] [diff] [review]
v2.0

So, this test is way more complex than it needs to be.  Really, we only need two downloads to actually test this.  You pause them both, then resume the bottommost one.  All you have to do at that point is ensure that it did not get a new index in the richlistbox.

Some comments below, but I'd like to see this test revised as stated so it's not as complex.
>+function runTest()
>+{
>+  const dmui = Cc["@mozilla.org/download-manager-ui;1"].
>+             getService(Ci.nsIDownloadManagerUI);
>+  const dm = Cc["@mozilla.org/download-manager;1"].
>+           getService(Ci.nsIDownloadManager);
s/const/let/

>+  const DLMGR_UI_DONE = "download-manager-ui-done";
>+  const DOWNLOADS = ["one", "two", "three", "four"];
>+  let dl = new Array();
if it's more than one, you should make it plural - dls
also, just set it to []
Attachment #331494 - Flags: review?(sdwilsh) → review-

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.

Assignee: poonaatsoc → nobody
Status: ASSIGNED → NEW
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: