446313 - Pressing <ENTER> on focused attachment does not trigger default download action (keyboard navigation)

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Thomas D. (:thomas8)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.0.1) Gecko/2008070208 Firefox/3.0.1
Build Identifier: version 3.0a1 (2008050715)

In TB's main mail window preview pane or standalone mail window, use mouse (due to Bug 373996) and focus and select one or more attachment icons. Press enter and nothing happens. Default download action should be triggered on each selected attachment (same as when double-clicking the icon).

Appears to me like it should be the most basic application behaviour in the world - default action of any object will be triggered by pressing enter on the selected (and focused) object...

Reporting against TB3alpha1 shredder.


Reproducible: Always

Steps to Reproduce:
1. Select (and focus) one ore more file attachments form TB's attachment panel.
2. Press <Enter> key.
3.
Actual Results:  
Nothing happens.

Expected Results:  
TB should trigger default download action for each of the selected attachments (open/save/ask). Pressing Enter on selected objects is no different from doubleclicking on these objects and should thus yield the same reaction, which is the default behaviour for almost any object throughout the entire system.

Some things are hard to believe, but true anyway...

Comment 1

[Wayne Mery (:wsmwk)]

confirming

Comment 2

[Thomas D. (:thomas8)]

This should be easy to fix, probably about 5 lines for the patch.
Structurally, something like

if attachments are selected AND focus in attachment panel AND Enter is pressed
  for each file in selection
    do default action
  next
end if

Which mxr file are we looking at?
Any volunteers?

Comment 3

[Nehal M]

Attachment: Proposed patch.

This patch adds the specified behaviour.

One issue I found is that the attachment pane can't get focus, and I had to manually override the style for the description element with:
  style="-moz-user-focus: normal;"

This was not the case in 3.0.1. I'm not sure why/where this change occurred. Can someone please look into this.

Comment 4

[Mark Banner (:standard8)]

(In reply to comment #3)
> One issue I found is that the attachment pane can't get focus, and I had to
> manually override the style for the description element with:
>   style="-moz-user-focus: normal;"
> 
> This was not the case in 3.0.1. I'm not sure why/where this change occurred.
> Can someone please look into this.

In which version can't you get focus on the attachment pane?

Comment 5

[Nehal M]

> In which version can't you get focus on the attachment pane?

I just compiled a clean copy that I obtained from the repository:

Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a1pre) Gecko/20100131 Shredder/3.2a1pre

Comment 6

[[e-mail]]

(In reply to comment #3)
> One issue I found is that the attachment pane can't get focus, and I had to
> manually override the style for the description element with:
>   style="-moz-user-focus: normal;"
> 
> This was not the case in 3.0.1. I'm not sure why/where this change occurred.
> Can someone please look into this.
Probably the same problem as bug 507394, which was the compose window version.

Comment 7

[Jim Porter (:squib)]

Fixed by bug 630759.