test_Microformats_count.html can fail sporadically with "Error thrown during test: test_MicroformatsAPI is not defined - got 0, expected 1"

RESOLVED FIXED

Status

()

RESOLVED FIXED
10 years ago
6 years ago

People

(Reporter: ted, Assigned: ted)

Tracking

({fixed1.9.0.2, intermittent-failure})

Trunk
x86
Windows XP
fixed1.9.0.2, intermittent-failure
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

This test failed on qm-win2k3-moz2-01, it looks like the iframe is loading before the script after it gets evaluated. Probably a fix would be to move the script up above the iframe to ensure it's evaluated beforehand. This probably only shows up on VMs because of the timing involved.
Created attachment 330764 [details] [diff] [review]
move the script block before the iframe

Here's a simple patch, just moves the script tag up before the iframe. The test succeeds for me with this change, should get rid of that race condition as well.
Assignee: mozilla → ted.mielczarek
Status: NEW → ASSIGNED
Attachment #330764 - Flags: review?
(Assignee)

Updated

10 years ago
Attachment #330764 - Flags: review? → review?(mozilla)

Updated

10 years ago
Attachment #330764 - Flags: review?(mozilla) → review+
Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/index.cgi/rev/37f174b07950
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Checked into CVS:
Checking in toolkit/components/microformats/tests/test_Microformats_count.html;
/cvsroot/mozilla/toolkit/components/microformats/tests/test_Microformats_count.h
tml,v  <--  test_Microformats_count.html
new revision: 1.2; previous revision: 1.1
done
Keywords: fixed1.9.0.2
Whiteboard: [orange]
Keywords: intermittent-failure
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.