446428 - Nickname adjustments made to connect (e.g add _) are kept when reconnecting

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[James Ross]

Basically, the problem is that the nickname used when connecting is not reset, so it keeps all the underscores or alternate nickname that was needed when connecting, even if the preferred nickname was subsequently reclaimed.

For example:
  1. Connect as "Silver".
  2. "Silver" is taken, so automatically tries "Silver_" which is free.
  3. Original "Silver" pings out and reclaim code changes to it from "Silver_".
  4. Disconnect and reconnect.
  5. Initial nickname used is "Silver_", but should have been "Silver".

Comment 1

[James Ross]

Attachment: Keep INITIAL_NICK in line with preferred nickname

When connecting, INITIAL_NICK is used by the IRC library; we update INITIAL_NICK when trying alternate nickname, but not when attempting to reclaim (which occurs a minimum of once at the end of the connect sequence if current != preferred nickname).

Comment 2

[:Gijs (he/him)]

Comment on attachment 330597 [details] [diff] [review]
Keep INITIAL_NICK in line with preferred nickname

r=me