Closed Bug 446433 Opened 12 years ago Closed 12 years ago

Add some zoom methods on deckbrowser

Categories

(Firefox for Android Graveyard :: Panning/Zooming, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED
fennec1.0m6

People

(Reporter: Gavin, Assigned: Gavin)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #330639 - Flags: review?(mark.finkle)
Comment on attachment 330639 [details] [diff] [review]
patch

>       <method name="zoom">
>         <parameter name="aDirection"/>
>         <body><![CDATA[
>+          var zoomDelta = 0.05; // 1/20
>           if (aDirection >= 0)

nit: Should we do nothing if aDirection == 0 ?
Attachment #330639 - Flags: review?(mark.finkle) → review+
added a check for aDirection == 0.

http://hg.mozilla.org/mobile-browser/index.cgi/rev/4a28c64a9b84
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
OS: Mac OS X → All
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → Fennec M6
verified zoom works in beta3
Status: RESOLVED → VERIFIED
Component: General → Panning/Zooming
You need to log in before you can comment on or make changes to this bug.