Open Bug 446449 Opened 16 years ago Updated 2 years ago

Automate litmus test Testcase ID #5052 - Completed download - single-digit date format

Categories

(Toolkit :: Downloads API, defect)

defect

Tracking

()

People

(Reporter: poonaatsoc, Unassigned)

References

()

Details

Attachments

(1 file, 1 obsolete file)

Proposed type of test: chrome

Proposed location of test: toolkit/mozapps/downloads/tests/chrome
Attached patch v1.0 (obsolete) — Splinter Review
Have run the test.  It passes
Attachment #330620 - Flags: review?(sdwilsh)
Attached patch v2.0Splinter Review
Test updated to accommodate the updated utils.js.  The test passes.
Attachment #330620 - Attachment is obsolete: true
Attachment #331496 - Flags: review?(sdwilsh)
Attachment #330620 - Flags: review?(sdwilsh)
Product: Firefox → Toolkit
Comment on attachment 331496 [details] [diff] [review]
v2.0

>+/**
>+ * This tests bug 446449.  This test basically checks that a download that has
>+ * finished downloading more than a week back, has its completed date/time in
>+ * the format - "December 2".
>+ */
same comment about the bug number stuff as in a previous bug

>+// Downloads are sorted by endTime, so make sure the end times are distinct
comment not needed

>+const DownloadData = [
>+  { name: "Date.patch",
>+    source: "https://bugzilla.mozilla.org/attachment.cgi?id=266520",
>+    target: gTestPath,
>+    startTime: 1180493839859230,
>+    endTime: new Date(2007, 11, 2) * 1000,
I'd like the end time to be Date.now() less a week so it's right on the edge

>+function runTest()
>+{
>+  const dmui = Cc["@mozilla.org/download-manager-ui;1"].
>+             getService(Ci.nsIDownloadManagerUI);
s/const/let/

>+      is(time, "December 2", "The date is in the single digit format as expected");
You should build the right string just like the download manager would do instead of guessing.  If we change this string, we'll have a needless test failure.

r=sdwilsh with those changes.
Attachment #331496 - Flags: review?(sdwilsh) → review+

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.

Assignee: poonaatsoc → nobody
Status: ASSIGNED → NEW
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: