446463 - DrawWidgetBackground can't snap to pixels properly, remove translation

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Markus Stange [:mstange]]

Attachment: Example of the bug (tree header cells with wrong width)

Before DrawWidgetBackground is called, nsCSSRendering::PaintBackgroundWithSC pushes a translation to the context and resets the widget rect's offset to 0. However, the width of the rect is not enough information to correctly pixel-snap the rect.

In bug 231313 I need the tabs to align neatly - it looks bad if they overlap / have gaps. Tree header cells also show this bug, see screenshot.

Comment 1

[Markus Stange [:mstange]]

Attachment: fix v0.1

Maybe we should add something for Windows / GTK, too; however, from my understanding of that code, it's not really necessary.

Comment 2

[Markus Stange [:mstange]]

Comment on attachment 330629 [details] [diff] [review]
fix v0.1

This is wrong... new patch coming

Comment 3

[Markus Stange [:mstange]]

Attachment: fix v0.2

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 330649 [details] [diff] [review]
fix v0.2

Removing translation is definitely the right way to go

Comment 5

[Markus Stange [:mstange]]

Attachment: fix v0.2 updated to trunk, no changes

The patch had bitrotted due to bug 444837.

Comment 6

[Stefan [:stefanh]]

http://hg.mozilla.org/index.cgi/mozilla-central/rev/cf5f9b3fd1b1