DrawWidgetBackground can't snap to pixels properly, remove translation

RESOLVED FIXED in mozilla1.9.1a2

Status

()

Core
Widget: Cocoa
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: mstange, Assigned: mstange)

Tracking

Trunk
mozilla1.9.1a2
All
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

Created attachment 330628 [details]
Example of the bug (tree header cells with wrong width)

Before DrawWidgetBackground is called, nsCSSRendering::PaintBackgroundWithSC pushes a translation to the context and resets the widget rect's offset to 0. However, the width of the rect is not enough information to correctly pixel-snap the rect.

In bug 231313 I need the tabs to align neatly - it looks bad if they overlap / have gaps. Tree header cells also show this bug, see screenshot.
Created attachment 330629 [details] [diff] [review]
fix v0.1

Maybe we should add something for Windows / GTK, too; however, from my understanding of that code, it's not really necessary.
Attachment #330629 - Flags: review?(roc)
Comment on attachment 330629 [details] [diff] [review]
fix v0.1

This is wrong... new patch coming
Attachment #330629 - Attachment is obsolete: true
Attachment #330629 - Flags: review?(roc)
Comment on attachment 330649 [details] [diff] [review]
fix v0.2

Removing translation is definitely the right way to go
Attachment #330649 - Flags: superreview+
Attachment #330649 - Flags: review?(roc)
Attachment #330649 - Flags: review+
Keywords: checkin-needed
Created attachment 331290 [details] [diff] [review]
fix v0.2 updated to trunk, no changes

The patch had bitrotted due to bug 444837.
Attachment #330649 - Attachment is obsolete: true

Comment 6

10 years ago
http://hg.mozilla.org/index.cgi/mozilla-central/rev/cf5f9b3fd1b1
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1a2

Updated

10 years ago
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.