446607 - Make Yahoo blocklist less generic

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: WebOps: Other, task)

Description

[Dave Townsend [:mossop]]

In bug 421993 we blocked the Yahoo Application State plugin. We spoke with Yahoo and advised then that they could put a version number on the end to allow future versions to not be blocklisted. However we've made the blocklist entry so generic that it is still blockling anything.

I think we need to change the description to match "^Yahoo Application State Plugin$". This should stop it matching a description with further text (version string f.e.) afterwards.

Comment 1

[Michael Morgan [:morgamic]]

update blplugins set name = '^Yahoo Application State Plugin$' where name = 'Yahoo Application State Plugin';

IT - could someone run this on the preview database so we can test there?

Comment 2

[Jeremy Orem [:oremj]]

mysql> update blplugins set name = '^Yahoo Application State Plugin$' where name =
    -> 'Yahoo Application State Plugin';
Query OK, 1 row affected (0.04 sec)
Rows matched: 1  Changed: 1  Warnings: 0

Comment 3

[Jeremy Orem [:oremj]]

(In reply to comment #2)
> mysql> update blplugins set name = '^Yahoo Application State Plugin$' where
> name =
>     -> 'Yahoo Application State Plugin';
> Query OK, 1 row affected (0.04 sec)
> Rows matched: 1  Changed: 1  Warnings: 0
> 

That was on preview.

Comment 4

[Michael Morgan [:morgamic]]

Ok, thanks.  Tony - could you test that it doesn't blocklist the new Yahoo stuff? Or Dave?

Comment 5

[Dave Townsend [:mossop]]

What is the url for the blocklist on preview?

Comment 6

[Michael Morgan [:morgamic]]

https://preview.addons.mozilla.org/blocklist/1/%7Bec8030f7-c20a-464f-9b0e-13a3a9e97384%7D/3.0/?nocache

Comment 7

[Dave Townsend [:mossop]]

Ok the change was not correct. It was the description field that we need to change, not the name field. Though I don't believe that making the name match more specific as we have does any harm either.

Comment 8

[Dave Townsend [:mossop]]

Mike, can we get things moving again here.

Comment 9

[Michael Morgan [:morgamic]]

update blplugins set description='^Yahoo Application State Plugin$' where name='^Yahoo Application State Plugin$';

IT - could we get this run on preview?

Comment 10

[Michael Morgan [:morgamic]]

If preview was reset after the last query was run, this works, too:

update blplugins set description='^Yahoo Application State Plugin$', name='^Yahoo Application State Plugin$' where name='Yahoo Application State Plugin';

Comment 11

[Jeremy Orem [:oremj]]

mysql> update blplugins set description='^Yahoo Application State Plugin$' where    -> name='^Yahoo Application State Plugin$';
Query OK, 1 row affected (0.04 sec)
Rows matched: 1  Changed: 1  Warnings: 0

Comment 12

[Dave Townsend [:mossop]]

I have tested and verified that the blocklist on preview correctly blocks the old yahoo state plugin and does not block the new one. Can we get this pushed live?

Comment 13

[Michael Morgan [:morgamic]]

IT - this needs to be run on the AMO database:

update blplugins set description='^Yahoo Application State Plugin$',
name='^Yahoo Application State Plugin$' where name='Yahoo Application State
Plugin';

Comment 14

[Reed Loden [:reed]]

mysql> update blplugins set description='^Yahoo Application State Plugin$', name='^Yahoo Application State Plugin$' where name='Yahoo Application State Plugin';
Query OK, 1 row affected (0.00 sec)
Rows matched: 1  Changed: 1  Warnings: 0