446647 - Checkboxes and radio buttons no longer scale in HTML

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect, P2)

Description

[Boris Zbarsky [:bzbarsky]]

Testcase is in the URL bar.

EXPECTED RESULTS: Checkbox and radio are 100px tall and wide

ACTUAL RESULTS:  The styles have no effect.

The reason for this is that nsNativeThemeCocoa::GetMinimumWidgetSize sets these sizes as not overridable.  This has been a problem since very early on, and it's not clear to me why it does that.  Windows does NOT do this, so this leads to significant layout differences.  In any case, this is clearly breaking the intended layout, so we shouldn't be doing it.

This worked fine in Firefox 2.

I suggest simply removing the PR_FALSE setting and letting the page override.  I see no reason this was done as it was initially.

Comment 1

[Markus Stange [:mstange]]

While we're at it, couldn't we just remove the minimum size completely? We can just scale down smaller controls which would also make zooming out more beautiful.
And we'd have to change the default sizes for XUL checkboxes / radiobuttons in pinstripe's checkbox.css / radio.css.

Comment 2

[Boris Zbarsky [:bzbarsky]]

The minimum size is the minimum size the OS theme engine will paint the control at.  We can remove that only if we drop the native theming.

Comment 3

[Markus Stange [:mstange]]

Attachment: Scaled checkboxes and radiobuttons

In nsNativeThemeCocoa.mm we're scaling native themed controls all over the place. I've created a patch that drops the minimum size for checkboxes and radiobuttons and still uses the native theming.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Sweet.  If we can do that, so much the better!

Comment 5

[Markus Stange [:mstange]]

I've attached the patch in bug 394892.

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

This really isn't a P1 blocker -- it's at best a P3 (before final) blocker, IMO.  P1 is blocking beta next week...

Comment 7

[Markus Stange [:mstange]]

Fixed by bug 394892.

Comment 8

[Aakash Desai [:aakashd]]

verified FIXED on builds: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090414 Minefield/3.6a1pre ID:20090414030735

and

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre) Gecko/20090414 Shiretoko/3.5b4pre ID:20090414035212