44665 - leak of xptiInterfaceInfo from CallQueryInterfaceOnProxy

Status: VERIFIED FIXED

(Core :: XPCOM, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I believe that nsProxyEventClass::CallQueryInterfaceOnProxy leaks the
xptiInterfaceInfo returned to it from iim->GetInfoForName.  I'm not sure if this
leak is in all cases (or if in some cases something else takes over the
reference).  However, looking through a massive refcount balance tree that I
will attach, it looks like this is responsible for leaks.

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: refcount balance tree, with --comptr (but *not* --ignore-balance)

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I accidentally attached that as HTML.  I'm not going to waste another 450K of
bugzilla disk space attaching it as text.  It can be read easily in View-Source.

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: proposed patch

Comment 4

[Doug Turner (:dougt)]

r=dougt.


if you need me to check it in, let me know.

Comment 5

[Doug Turner (:dougt)]

patch checked in

Comment 6

[leger]

Setting QA Contact to [e-mail].  David, can you verify when 
2000-07-07 build is available later today?  Thanks!

Comment 7

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Marking as verified.  Tinderbox leak stats dropped from 2 objects/5 refs to 2 
objects / 2 refs when this was checked in.  I suspect the other 2 refs may be 
owned by something else leaked, rather than leaked themselves, but it's worth 
checking.  However, this leak is fixed.