leak of xptiInterfaceInfo from CallQueryInterfaceOnProxy

VERIFIED FIXED

Status

()

Core
XPCOM
P3
normal
VERIFIED FIXED
18 years ago
18 years ago

People

(Reporter: dbaron, Assigned: dougt)

Tracking

({mlk})

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [tind-mlk])

Attachments

(2 attachments)

I believe that nsProxyEventClass::CallQueryInterfaceOnProxy leaks the
xptiInterfaceInfo returned to it from iim->GetInfoForName.  I'm not sure if this
leak is in all cases (or if in some cases something else takes over the
reference).  However, looking through a massive refcount balance tree that I
will attach, it looks like this is responsible for leaks.
Keywords: mlk
Whiteboard: [tind-mlk]
Created attachment 11050 [details]
refcount balance tree, with --comptr (but *not* --ignore-balance)
I accidentally attached that as HTML.  I'm not going to waste another 450K of
bugzilla disk space attaching it as text.  It can be read easily in View-Source.
Created attachment 11060 [details] [diff] [review]
proposed patch
Keywords: patch
(Assignee)

Comment 4

18 years ago
r=dougt.


if you need me to check it in, let me know.
(Assignee)

Comment 5

18 years ago
patch checked in
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 6

18 years ago
Setting QA Contact to dbaron@fas.harvard.edu.  David, can you verify when 
2000-07-07 build is available later today?  Thanks!
QA Contact: leger → dbaron
Marking as verified.  Tinderbox leak stats dropped from 2 objects/5 refs to 2 
objects / 2 refs when this was checked in.  I suspect the other 2 refs may be 
owned by something else leaked, rather than leaked themselves, but it's worth 
checking.  However, this leak is fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.