44699 - IMAP does not check result param from nsIMsgAccountManager::FindServer()

Status: VERIFIED FIXED

(MailNews Core :: Networking: IMAP, defect, P3)

Description

[Chris Waterson]

So I get a crash in IMAP sometimes reading messages. The stack is below. It
looks like the problem is that aServer (grr -- it's a local variable, not an
argument, why hungarian "a") is null here:

http://lxr.mozilla.org/mozilla/source/mailnews/mailnews/imap/src/nsImapService#2727

So it seems that nsIMsgAccountManager::FindServer() is returning success but
leaving the out parameter null, here

http://lxr.mozilla.org/mozilla/source/mailnews/mailnews/imap/src/nsImapService#2721

This seems to be a pretty obvious code-level problem: according to alecf,
FindServer() is allowed to return null. I can't tell you how to reproduce it.
Read mail for a while ;-).

Comment 1

[Scott MacGregor]

these links are actually bogus. Be sure to insert .cpp if you want to look at them.

load balancing to jeff.

I've been reading mail all day with a tip build and haven't seen this crash yet.
I'm not sure why waterson is so lucky!

Comment 2

[jefft]

accepting.. adding crash keyword...

Comment 3

[jefft]

Attachment: A safety guard.

Comment 4

[Alec Flett]

Thanks Jeff
Actually, why don't you put
NS_ENSURE_TRUE(aServer, NS_ERROR_FAILURE);

that way one of us can catch the assertion if we ever see it

Comment 5

[jefft]

Even better, Alec. I will do so.

Comment 6

[scottputterman]

nominating for nsbeta2 given that we have a fix that will prevent a crash that
can occur when reading messages.

Comment 7

[jefft]

fix checked in.

Comment 8

[fenella]

Old bug. Can not re-produce the problem. Let's close it.